Re: [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-05-25 Thread Shawn Guo
Hi Uwe, On Wed, May 25, 2011 at 08:46:19AM +0200, Uwe Kleine-König wrote: > Hello Shawn, > > > > > +#ifndef CONFIG_MMC_SDHCI_ESDHC_IMX > > > > +#define cpu_is_mx25() (0) > > > > +#define cpu_is_mx35() (0) > > > > +#define cpu_is_mx51() (0) > > > > +#define cpu_is_imx() (0) > > > > +#else > >

Re: [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-05-24 Thread Uwe Kleine-König
Hello Shawn, > > > +#ifndef CONFIG_MMC_SDHCI_ESDHC_IMX > > > +#define cpu_is_mx25()(0) > > > +#define cpu_is_mx35()(0) > > > +#define cpu_is_mx51()(0) > > > +#define cpu_is_imx() (0) > > > +#else > > > +#define cpu_is_imx() (1) > > > +#endif > > > > ... e.g. that looks a bit f

Re: [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-05-24 Thread Shawn Guo
On Tue, May 24, 2011 at 09:40:54PM +0200, Wolfram Sang wrote: > On Thu, May 05, 2011 at 09:22:56PM +0800, Shawn Guo wrote: > > This patch is to consolidate SDHCI driver for Freescale eSDHC > > controller found on both MPCxxx and i.MX platforms. It merges > > sdhci-of-esdhc.c into sdhci-esdhc.c, so

Re: [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-05-24 Thread Wolfram Sang
On Thu, May 05, 2011 at 09:22:56PM +0800, Shawn Guo wrote: > This patch is to consolidate SDHCI driver for Freescale eSDHC > controller found on both MPCxxx and i.MX platforms. It merges > sdhci-of-esdhc.c into sdhci-esdhc.c, so that the same pair of > .probe/.remove hook works with eSDHC for two

Re: [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-05-19 Thread Wolfram Sang
> +config MMC_SDHCI_ESDHC > + bool > + depends on MMC_SDHCI > + select MMC_SDHCI_PLTFM > + help > + This selects SDHCI driver for Freescale eSDHC controller. bool is not a good choice here, because if ESDHC_IMX is selected as a module (-m), it will get converted here to buil

Re: [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-05-05 Thread Anton Vorontsov
On Thu, May 05, 2011 at 09:22:56PM +0800, Shawn Guo wrote: > This patch is to consolidate SDHCI driver for Freescale eSDHC > controller found on both MPCxxx and i.MX platforms. It merges > sdhci-of-esdhc.c into sdhci-esdhc.c, so that the same pair of > .probe/.remove hook works with eSDHC for two

[PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-05-05 Thread Shawn Guo
This patch is to consolidate SDHCI driver for Freescale eSDHC controller found on both MPCxxx and i.MX platforms. It merges sdhci-of-esdhc.c into sdhci-esdhc.c, so that the same pair of .probe/.remove hook works with eSDHC for two platforms. As the results, sdhci-of-esdhc.c and sdhci-esdhc.h are