Re: [PATCH v2 5/7] counter: add FlexTimer Module Quadrature decoder counter driver

2019-03-11 Thread Jonathan Cameron
On Wed, 6 Mar 2019 12:12:06 +0100 Patrick Havelange wrote: > This driver exposes the counter for the quadrature decoder of the > FlexTimer Module, present in the LS1021A soc. > > Signed-off-by: Patrick Havelange A few really trivial bits inline to add to William's feedback. Otherwise I'm happy

Re: [PATCH v2 5/7] counter: add FlexTimer Module Quadrature decoder counter driver

2019-03-11 Thread Patrick Havelange
On Thu, Mar 7, 2019 at 12:32 PM William Breathitt Gray wrote: > > +/* > > + * take mutex > > + * call ftm_clear_write_protection > > + * update settings > > + * call ftm_set_write_protection > > + * release mutex > > + */ > > Jonathan mentioned it before in the previous review, and I think I agree

Re: [PATCH v2 5/7] counter: add FlexTimer Module Quadrature decoder counter driver

2019-03-07 Thread William Breathitt Gray
On Wed, Mar 06, 2019 at 12:12:06PM +0100, Patrick Havelange wrote: > This driver exposes the counter for the quadrature decoder of the > FlexTimer Module, present in the LS1021A soc. > > Signed-off-by: Patrick Havelange > --- > Changes v2 > - Rebased on new counter subsystem > - Cleaned up incl

[PATCH v2 5/7] counter: add FlexTimer Module Quadrature decoder counter driver

2019-03-06 Thread Patrick Havelange
This driver exposes the counter for the quadrature decoder of the FlexTimer Module, present in the LS1021A soc. Signed-off-by: Patrick Havelange --- Changes v2 - Rebased on new counter subsystem - Cleaned up included headers - Use devm_ioremap() - Correct order of devm_ and unmanaged resource