Re: [PATCH v2 5/6] powerpc/smp: Add read_mostly attribute

2023-10-19 Thread Srikar Dronamraju
* Peter Zijlstra [2023-10-19 09:51:27]: > On Wed, Oct 18, 2023 at 10:07:45PM +0530, Srikar Dronamraju wrote: > > There are some variables that are only updated at boot time. > > So add read_mostly attribute to such variables > > You don't have __ro_after_init ? Michael also responded with the s

Re: [PATCH v2 5/6] powerpc/smp: Add read_mostly attribute

2023-10-19 Thread Peter Zijlstra
On Wed, Oct 18, 2023 at 10:07:45PM +0530, Srikar Dronamraju wrote: > There are some variables that are only updated at boot time. > So add read_mostly attribute to such variables You don't have __ro_after_init ?

Re: [PATCH v2 5/6] powerpc/smp: Add read_mostly attribute

2023-10-18 Thread Michael Ellerman
Srikar Dronamraju writes: > There are some variables that are only updated at boot time. > So add read_mostly attribute to such variables If they're only updated at boot time then __ro_after_init would be the better annotation. cheers > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kern

[PATCH v2 5/6] powerpc/smp: Add read_mostly attribute

2023-10-18 Thread Srikar Dronamraju
There are some variables that are only updated at boot time. So add read_mostly attribute to such variables Signed-off-by: Srikar Dronamraju --- arch/powerpc/kernel/smp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kerne