Re: [PATCH v2 4/6] i2c: pasemi: Improve error recovery

2025-04-27 Thread Sven Peter
Hi, On Thu, Apr 17, 2025, at 15:07, Andi Shyti wrote: > Hi Sven, Hector, > > ... > >> +/* >> + * The hardware (supposedly) has a 25ms timeout for clock stretching, thus >> + * use 100ms here which should be plenty. >> + */ >> +#define TRANSFER_TIMEOUT_MS 100 > > Please use the PASEMI prefix here.

Re: [PATCH v2 4/6] i2c: pasemi: Improve error recovery

2025-04-17 Thread Andi Shyti
Hi Sven, Hector, ... > +/* > + * The hardware (supposedly) has a 25ms timeout for clock stretching, thus > + * use 100ms here which should be plenty. > + */ > +#define TRANSFER_TIMEOUT_MS 100 Please use the PASEMI prefix here. TRANSFER_TIMEOUT_MS it's not a naming belonging to this driver. 100

Re: [PATCH v2 4/6] i2c: pasemi: Improve error recovery

2025-04-15 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig Le Tue , Apr 15, 2025 at 03:36:58PM +, Sven Peter via B4 Relay a écrit : > From: Hector Martin > > The hardware (supposedly) has a 25ms timeout for clock stretching > and the driver uses 100ms which should be plenty. The error > reocvery itself is however lack

[PATCH v2 4/6] i2c: pasemi: Improve error recovery

2025-04-15 Thread Sven Peter via B4 Relay
From: Hector Martin The hardware (supposedly) has a 25ms timeout for clock stretching and the driver uses 100ms which should be plenty. The error reocvery itself is however lacking. Add handling for all the missing error condition, and better recovery in pasemi_smb_clear(). Also move the timeout