Re: [PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-12 Thread Daniel Axtens
Hi Christophe, I think I've covered everything you've mentioned in the v3 I'm about to send, except for: >> +/* mark early shadow region as RO and wipe */ >> +pte = __pte(__pa(kasan_early_shadow_page) | >> +pgprot_val(PAGE_KERNEL_RO) | _PAGE_PTE); > > Any reason for _PAGE_

Re: [PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-12 Thread Andrey Ryabinin
On 12/11/19 5:24 PM, Daniel Axtens wrote: > Hi Balbir, > > +Discontiguous memory can occur when you have a machine with memory spread > +across multiple nodes. For example, on a Talos II with 64GB of RAM: > + > + - 32GB runs from 0x0 to 0x_0008__, > + - then there's

Re: [PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-12 Thread Christophe Leroy
Le 12/12/2019 à 08:42, Balbir Singh a écrit : On 12/12/19 1:24 am, Daniel Axtens wrote: Hi Balbir, +Discontiguous memory can occur when you have a machine with memory spread +across multiple nodes. For example, on a Talos II with 64GB of RAM: + + - 32GB runs from 0x0 to 0x_0008__0

Re: [PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-11 Thread Balbir Singh
On 12/12/19 1:24 am, Daniel Axtens wrote: > Hi Balbir, > > +Discontiguous memory can occur when you have a machine with memory spread > +across multiple nodes. For example, on a Talos II with 64GB of RAM: > + > + - 32GB runs from 0x0 to 0x_0008__, > + - then ther

Re: [PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-11 Thread Daniel Axtens
Hi Balbir, +Discontiguous memory can occur when you have a machine with memory spread +across multiple nodes. For example, on a Talos II with 64GB of RAM: + + - 32GB runs from 0x0 to 0x_0008__, + - then there's a gap, + - then the final 32GB runs from 0x00

Re: [PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-11 Thread Balbir Singh
On 11/12/19 4:21 pm, Daniel Axtens wrote: > Hi Balbir, > >>> +Discontiguous memory can occur when you have a machine with memory spread >>> +across multiple nodes. For example, on a Talos II with 64GB of RAM: >>> + >>> + - 32GB runs from 0x0 to 0x_0008__, >>> + - then there's a gap,

Re: [PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-10 Thread Daniel Axtens
Hi Balbir, >> +Discontiguous memory can occur when you have a machine with memory spread >> +across multiple nodes. For example, on a Talos II with 64GB of RAM: >> + >> + - 32GB runs from 0x0 to 0x_0008__, >> + - then there's a gap, >> + - then the final 32GB runs from 0x_2000_

Re: [PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-10 Thread kbuild test robot
Hi Daniel, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20191209] [also build test ERROR on linus/master v5.5-rc1] [cannot apply to powerpc/next asm-generic/master v5.4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-10 Thread Balbir Singh
On 10/12/19 3:47 pm, Daniel Axtens wrote: > KASAN support on powerpc64 is challenging: > > - We want to be able to support inline instrumentation so as to be >able to catch global and stack issues. > > - We run some code in real mode after boot, most notably a lot of >KVM code. We'd

Re: [PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-09 Thread Christophe Leroy
Le 10/12/2019 à 05:47, Daniel Axtens a écrit : KASAN support on powerpc64 is challenging: - We want to be able to support inline instrumentation so as to be able to catch global and stack issues. - We run some code in real mode after boot, most notably a lot of KVM code. We'd lik

[PATCH v2 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-09 Thread Daniel Axtens
KASAN support on powerpc64 is challenging: - We want to be able to support inline instrumentation so as to be able to catch global and stack issues. - We run some code in real mode after boot, most notably a lot of KVM code. We'd like to be able to instrument this. [For those not imme