Re: [PATCH v2 4/4] Freescale enhanced Local Bus Controller FCM NAND support.

2007-12-14 Thread Arnd Bergmann
On Friday 14 December 2007, Anton Vorontsov wrote: > > >Maybe this desires its own header? > > > > It can be factored out if anything else ever uses it. > > It's just confusing to parse lbc-specific and nand-specific code > placed in the same file. In that case, you could argue for splitting the

Re: [PATCH v2 4/4] Freescale enhanced Local Bus Controller FCM NAND support.

2007-12-14 Thread Anton Vorontsov
On Fri, Dec 14, 2007 at 01:33:41PM -0600, Scott Wood wrote: > Anton Vorontsov wrote: > >On Fri, Dec 14, 2007 at 12:56:24PM -0600, Scott Wood wrote: > >>+#if 0 > >>+#define ELBC_NAND_DEBUG_LVL 6 > >>+#endif > >>+ > >>+#ifdef ELBC_NAND_DEBUG_LVL > >>+static int fcm_debug_level = ELBC_NAND_DEBUG_LVL;

Re: [PATCH v2 4/4] Freescale enhanced Local Bus Controller FCM NAND support.

2007-12-14 Thread Scott Wood
Anton Vorontsov wrote: > On Fri, Dec 14, 2007 at 12:56:24PM -0600, Scott Wood wrote: >> +#if 0 >> +#define ELBC_NAND_DEBUG_LVL 6 >> +#endif >> + >> +#ifdef ELBC_NAND_DEBUG_LVL >> +static int fcm_debug_level = ELBC_NAND_DEBUG_LVL; >> +#define FCM_DEBUG(n, args...) \ >> +do {

Re: [PATCH v2 4/4] Freescale enhanced Local Bus Controller FCM NAND support.

2007-12-14 Thread Anton Vorontsov
On Fri, Dec 14, 2007 at 12:56:24PM -0600, Scott Wood wrote: > Signed-off-by: Nick Spence <[EMAIL PROTECTED]> > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > Respun according to feedback; also, fixed a couple direct accesses > of iomem. > > drivers/mtd/nand/Kconfig |9 + > driv

[PATCH v2 4/4] Freescale enhanced Local Bus Controller FCM NAND support.

2007-12-14 Thread Scott Wood
Signed-off-by: Nick Spence <[EMAIL PROTECTED]> Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- Respun according to feedback; also, fixed a couple direct accesses of iomem. drivers/mtd/nand/Kconfig |9 + drivers/mtd/nand/Makefile|1 + drivers/mtd/nand/fsl_elbc_nand.c | 12