Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-11 Thread Yijing Wang
>> In my idea, dev->pcie_cap(here is pci_dev->pcie_cap) will update in >> set_pcie_port_type() function, >> and this function always be called after allocate pci device. We get pci_dev >> by eeh_dev_to_pci_dev(), >> I think pci_dev has been initialized completely. >> >>> This function has possibi

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-11 Thread Gavin Shan
On Fri, Oct 11, 2013 at 03:28:02PM +0800, Yijing Wang wrote: >On 2013/10/11 14:53, Gavin Shan wrote: >> On Fri, Oct 11, 2013 at 02:33:58PM +0800, Yijing Wang wrote: >>> On 2013/10/11 14:16, Gavin Shan wrote: On Fri, Oct 11, 2013 at 04:49:56PM +1100, Benjamin Herrenschmidt wrote: > On Fri,

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-11 Thread Yijing Wang
On 2013/10/11 14:53, Gavin Shan wrote: > On Fri, Oct 11, 2013 at 02:33:58PM +0800, Yijing Wang wrote: >> On 2013/10/11 14:16, Gavin Shan wrote: >>> On Fri, Oct 11, 2013 at 04:49:56PM +1100, Benjamin Herrenschmidt wrote: On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: > On Thu, Sep

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-10 Thread Gavin Shan
On Fri, Oct 11, 2013 at 02:33:58PM +0800, Yijing Wang wrote: >On 2013/10/11 14:16, Gavin Shan wrote: >> On Fri, Oct 11, 2013 at 04:49:56PM +1100, Benjamin Herrenschmidt wrote: >>> On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: On Thu, Sep 05, 2013 at 03:55:27PM +0800, Yijing Wang wrot

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-10 Thread Yijing Wang
On 2013/10/11 13:49, Benjamin Herrenschmidt wrote: > On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: >> On Thu, Sep 05, 2013 at 03:55:27PM +0800, Yijing Wang wrote: >>> Use pci_is_pcie() to simplify code. >>> >>> Acked-by: Kumar Gala >>> Reviewed-by: Gavin Shan >>> Signed-off-by: Yijing W

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-10 Thread Yijing Wang
On 2013/10/11 14:16, Gavin Shan wrote: > On Fri, Oct 11, 2013 at 04:49:56PM +1100, Benjamin Herrenschmidt wrote: >> On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: >>> On Thu, Sep 05, 2013 at 03:55:27PM +0800, Yijing Wang wrote: Use pci_is_pcie() to simplify code. Acked-by: K

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-10 Thread Gavin Shan
On Fri, Oct 11, 2013 at 04:49:56PM +1100, Benjamin Herrenschmidt wrote: >On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: >> On Thu, Sep 05, 2013 at 03:55:27PM +0800, Yijing Wang wrote: >> > Use pci_is_pcie() to simplify code. >> > >> > Acked-by: Kumar Gala >> > Reviewed-by: Gavin Shan >>

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-10-10 Thread Benjamin Herrenschmidt
On Fri, 2013-09-06 at 14:30 -0600, Bjorn Helgaas wrote: > On Thu, Sep 05, 2013 at 03:55:27PM +0800, Yijing Wang wrote: > > Use pci_is_pcie() to simplify code. > > > > Acked-by: Kumar Gala > > Reviewed-by: Gavin Shan > > Signed-off-by: Yijing Wang > > Cc: Gavin Shan > > Cc: Benjamin Herrenschmi

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-09-06 Thread Bjorn Helgaas
On Thu, Sep 05, 2013 at 03:55:27PM +0800, Yijing Wang wrote: > Use pci_is_pcie() to simplify code. > > Acked-by: Kumar Gala > Reviewed-by: Gavin Shan > Signed-off-by: Yijing Wang > Cc: Gavin Shan > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linu

[PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-09-05 Thread Yijing Wang
Use pci_is_pcie() to simplify code. Acked-by: Kumar Gala Reviewed-by: Gavin Shan Signed-off-by: Yijing Wang Cc: Gavin Shan Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ker...@vger.kernel.org --- arch/powerpc/kernel/eeh.c |3 +-- arch/powe