Re: [PATCH v2 3/5] xhci: Add rmb() between reading event validity & event data access.

2011-03-29 Thread Benjamin Herrenschmidt
On Tue, 2011-03-29 at 11:56 -0700, Dmitry Torokhov wrote: > > + /* > > + * Barrier between reading the TRB_CYCLE (valid) flag above > and any > > + * speculative reads of the event's flags/data below. > > + */ > > + rmb(); > > /* FIXME: Handle more event types. */ > >

Re: [PATCH v2 3/5] xhci: Add rmb() between reading event validity & event data access.

2011-03-29 Thread Dmitry Torokhov
On Sunday, March 27, 2011 09:52:57 pm Matt Evans wrote: > On weakly-ordered systems, the reading of an event's content must occur > after reading the event's validity. > > Signed-off-by: Matt Evans > --- > Segher, thanks for the comment; explanation added. > > drivers/usb/host/xhci-ring.c |

Re: [PATCH v2 3/5] xhci: Add rmb() between reading event validity & event data access.

2011-03-28 Thread Sarah Sharp
This patch looks fine, thanks! Sarah Sharp On Mon, Mar 28, 2011 at 03:52:57PM +1100, Matt Evans wrote: > On weakly-ordered systems, the reading of an event's content must occur > after reading the event's validity. > > Signed-off-by: Matt Evans > --- > Segher, thanks for the comment; explanatio

[PATCH v2 3/5] xhci: Add rmb() between reading event validity & event data access.

2011-03-27 Thread Matt Evans
On weakly-ordered systems, the reading of an event's content must occur after reading the event's validity. Signed-off-by: Matt Evans --- Segher, thanks for the comment; explanation added. drivers/usb/host/xhci-ring.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/