Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings

2022-01-18 Thread Nicholas Piggin
Excerpts from Dave Hansen's message of January 19, 2022 3:28 am: > On 1/17/22 6:46 PM, Nicholas Piggin wrote: >>> This all sounds very fragile to me. Every time a new architecture would >>> get added for huge vmalloc() support, the developer needs to know to go >>> find that architecture's module_

Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings

2022-01-18 Thread Dave Hansen
On 1/17/22 6:46 PM, Nicholas Piggin wrote: >> This all sounds very fragile to me. Every time a new architecture would >> get added for huge vmalloc() support, the developer needs to know to go >> find that architecture's module_alloc() and add this flag. > This is documented in the Kconfig. > >

Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings

2022-01-17 Thread Nicholas Piggin
Excerpts from Dave Hansen's message of December 29, 2021 2:14 am: > On 12/28/21 2:26 AM, Kefeng Wang wrote: There are some disadvantages about this feature[2], one of the main concerns is the possible memory fragmentation/waste in some scenarios, also archs must ensure that any arch

Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings

2022-01-15 Thread Christophe Leroy
Le 29/12/2021 à 12:01, Kefeng Wang a écrit : > > On 2021/12/29 0:14, Dave Hansen wrote: >> On 12/28/21 2:26 AM, Kefeng Wang wrote: > There are some disadvantages about this feature[2], one of the main > concerns is the possible memory fragmentation/waste in some scenarios, > also arc

Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings

2022-01-15 Thread Christophe Leroy
Le 28/12/2021 à 17:14, Dave Hansen a écrit : > On 12/28/21 2:26 AM, Kefeng Wang wrote: There are some disadvantages about this feature[2], one of the main concerns is the possible memory fragmentation/waste in some scenarios, also archs must ensure that any arch specific vmalloc al

Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings

2022-01-15 Thread Christophe Leroy
Le 28/12/2021 à 11:26, Kefeng Wang a écrit : > > On 2021/12/27 23:56, Dave Hansen wrote: >> On 12/27/21 6:59 AM, Kefeng Wang wrote: >>> This patch select HAVE_ARCH_HUGE_VMALLOC to let X86_64 and X86_PAE >>> support huge vmalloc mappings. >> In general, this seems interesting and the diff is simp

Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings

2022-01-15 Thread Christophe Leroy
Le 27/12/2021 à 15:59, Kefeng Wang a écrit : > This patch select HAVE_ARCH_HUGE_VMALLOC to let X86_64 and X86_PAE > support huge vmalloc mappings. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: "H. Peter Anvin" > Signed-off-by: Kefeng Wang > --- >

Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings

2021-12-28 Thread Dave Hansen
On 12/28/21 2:26 AM, Kefeng Wang wrote: >>> There are some disadvantages about this feature[2], one of the main >>> concerns is the possible memory fragmentation/waste in some scenarios, >>> also archs must ensure that any arch specific vmalloc allocations that >>> require PAGE_SIZE mappings(eg, mo

Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings

2021-12-27 Thread Dave Hansen
On 12/27/21 6:59 AM, Kefeng Wang wrote: > This patch select HAVE_ARCH_HUGE_VMALLOC to let X86_64 and X86_PAE > support huge vmalloc mappings. In general, this seems interesting and the diff is simple. But, I don't see _any_ x86-specific data. I think the bare minimum here would be a few kernel c