Re: [PATCH v2 2/8] powerpc/eeh: More relexed hotplug criterion

2015-10-13 Thread Gavin Shan
On Wed, Oct 14, 2015 at 10:48:15AM +1100, Daniel Axtens wrote: >Gavin Shan writes: >> I think you're talking about the situation reported from the bug. It's >> CAN_RECOVER instead of NONE returned from error_detected(). With the >> CAN_RECOVER, the driver hopes the EEH core to enable the IO path s

Re: [PATCH v2 2/8] powerpc/eeh: More relexed hotplug criterion

2015-10-13 Thread Daniel Axtens
Gavin Shan writes: > I think you're talking about the situation reported from the bug. It's > CAN_RECOVER instead of NONE returned from error_detected(). With the > CAN_RECOVER, the driver hopes the EEH core to enable the IO path so that > it can collect diag-data from IO space at late point. O

Re: [PATCH v2 2/8] powerpc/eeh: More relexed hotplug criterion

2015-10-12 Thread Gavin Shan
On Tue, Oct 13, 2015 at 01:48:54PM +1100, Daniel Axtens wrote: >Gavin Shan writes: > >> Danienl, The issue is tracked by IBM's bugzilla 127612 reported from Nvida >> private GPU drivers. I tried to find the source code from upstream kernel, >> but failed. > >OK. So I've read the internal bug, and

Re: [PATCH v2 2/8] powerpc/eeh: More relexed hotplug criterion

2015-10-12 Thread Daniel Axtens
Gavin Shan writes: > Danienl, The issue is tracked by IBM's bugzilla 127612 reported from Nvida > private GPU drivers. I tried to find the source code from upstream kernel, > but failed. OK. So I've read the internal bug, and I'm going to do my best to summarise without including confidential in

Re: [PATCH v2 2/8] powerpc/eeh: More relexed hotplug criterion

2015-10-12 Thread Gavin Shan
On Tue, Oct 13, 2015 at 09:55:53AM +1100, Daniel Axtens wrote: >> Currently, we rely on the existence of struct pci_driver::err_handler >> to judge if the corresponding PCI device should be unplugged during >> EEH recovery (partially hotplug case). However, it's not elaborate. >> some device driver

Re: [PATCH v2 2/8] powerpc/eeh: More relexed hotplug criterion

2015-10-12 Thread Daniel Axtens
Gavin Shan writes: Hi Gavin, > Currently, we rely on the existence of struct pci_driver::err_handler > to judge if the corresponding PCI device should be unplugged during > EEH recovery (partially hotplug case). However, it's not elaborate. > some device drivers are implementing part of the EEH

[PATCH v2 2/8] powerpc/eeh: More relexed hotplug criterion

2015-10-07 Thread Gavin Shan
Currently, we rely on the existence of struct pci_driver::err_handler to judge if the corresponding PCI device should be unplugged during EEH recovery (partially hotplug case). However, it's not elaborate. some device drivers are implementing part of the EEH error handlers to collect diag-data. Tha