Re: [PATCH v2 2/2] powerpc/mm: call H_BLOCK_REMOVE when supported

2019-09-19 Thread Laurent Dufour
Le 18/09/2019 à 15:42, Michael Ellerman a écrit : Hi Laurent, Few comments ... Hi Michael, Thanks for the review and the nitpicking ;) Laurent Dufour writes: Now we do not call _BLOCK_REMOVE all the time when the feature is exhibited. This isn't true until after the patch is applied, ie

Re: [PATCH v2 2/2] powerpc/mm: call H_BLOCK_REMOVE when supported

2019-09-18 Thread Michael Ellerman
Hi Laurent, Few comments ... Laurent Dufour writes: > Now we do not call _BLOCK_REMOVE all the time when the feature is > exhibited. This isn't true until after the patch is applied, ie. the tense is wrong. The rest of the change log explains things fine, so just drop that sentence I think. Ca

[PATCH v2 2/2] powerpc/mm: call H_BLOCK_REMOVE when supported

2019-09-16 Thread Laurent Dufour
Now we do not call _BLOCK_REMOVE all the time when the feature is exhibited. Depending on the hardware and the hypervisor, the hcall H_BLOCK_REMOVE may not be able to process all the page size for a segment base page size, as reported by the TLB Invalidate Characteristics.o For each couple base s