Re: [PATCH v2 1/6] net: wan: Add support for QMC HDLC

2024-02-05 Thread Herve Codina
On Mon, 05 Feb 2024 16:49:33 +0100 Paolo Abeni wrote: [... > > > > > > In general is quite bad that the existing infra does not allow > > > leveraging NAPI. Have you considered expanding the QMC to accomodate > > > such user? > > > > I cannot mask/unmask the 'end of transfer' interrupt. > > I

Re: [PATCH v2 1/6] net: wan: Add support for QMC HDLC

2024-02-05 Thread Paolo Abeni
On Mon, 2024-02-05 at 15:22 +0100, Herve Codina wrote: > Hi Paolo, > > On Thu, 01 Feb 2024 12:41:32 +0100 > Paolo Abeni wrote: > > [...] > > > +static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device > > > *netdev) > > > +{ > > > + return dev_to_hdlc(netdev)->priv; > > > +} > > >

Re: [PATCH v2 1/6] net: wan: Add support for QMC HDLC

2024-02-05 Thread Herve Codina
Hi Paolo, On Thu, 01 Feb 2024 12:41:32 +0100 Paolo Abeni wrote: [...] > > +static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device > > *netdev) > > +{ > > + return dev_to_hdlc(netdev)->priv; > > +} > > Please, no 'inline' function in c files. You could move this function > and

Re: [PATCH v2 1/6] net: wan: Add support for QMC HDLC

2024-02-01 Thread Paolo Abeni
On Tue, 2024-01-30 at 09:40 +0100, Herve Codina wrote: > The QMC HDLC driver provides support for HDLC using the QMC (QUICC > Multichannel Controller) to transfer the HDLC data. > > Signed-off-by: Herve Codina > Reviewed-by: Christophe Leroy > Acked-by: Jakub Kicinski > --- > drivers/net/wan/K

[PATCH v2 1/6] net: wan: Add support for QMC HDLC

2024-01-30 Thread Herve Codina
The QMC HDLC driver provides support for HDLC using the QMC (QUICC Multichannel Controller) to transfer the HDLC data. Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy Acked-by: Jakub Kicinski --- drivers/net/wan/Kconfig| 12 + drivers/net/wan/Makefile | 1 + drivers/