Re: [PATCH v2 1/4] pci/msi: Move "no_64bit_msi" flag from powerpc to generic pci_dev

2014-10-02 Thread Bjorn Helgaas
On Thu, Oct 2, 2014 at 3:01 PM, Benjamin Herrenschmidt wrote: > On Thu, 2014-10-02 at 09:31 -0600, Bjorn Helgaas wrote: > >> > So this moves the flag to struct pci_dev instead and adjusts the >> > corresponding arch/powerpc code to look for it there. At this point, >> > there is no attempt at maki

Re: [PATCH v2 1/4] pci/msi: Move "no_64bit_msi" flag from powerpc to generic pci_dev

2014-10-02 Thread Benjamin Herrenschmidt
On Thu, 2014-10-02 at 09:31 -0600, Bjorn Helgaas wrote: > > So this moves the flag to struct pci_dev instead and adjusts the > > corresponding arch/powerpc code to look for it there. At this point, > > there is no attempt at making other architectures honor it just yet, > > though it appears that

Re: [PATCH v2 1/4] pci/msi: Move "no_64bit_msi" flag from powerpc to generic pci_dev

2014-10-02 Thread Bjorn Helgaas
On Thu, Oct 02, 2014 at 10:34:12AM +1000, Benjamin Herrenschmidt wrote: > > Some devices have broken 64-bit MSI support which only support some > address bits (40 to 48 typically). This doesn't work on some platforms > such as POWER servers, so we need a quirk. > > Currently we keep a flag in a p

Re: [PATCH v2 1/4] pci/msi: Move "no_64bit_msi" flag from powerpc to generic pci_dev

2014-10-01 Thread Stephen Rothwell
Hi Ben, On Thu, 02 Oct 2014 10:33:32 +1000 Benjamin Herrenschmidt wrote: > > --- a/arch/powerpc/kernel/pci_64.c > +++ b/arch/powerpc/kernel/pci_64.c > @@ -269,10 +269,7 @@ EXPORT_SYMBOL(pcibus_to_node); > > static void quirk_radeon_32bit_msi(struct pci_dev *dev) > { > - struct pci_dn *pd

[PATCH v2 1/4] pci/msi: Move "no_64bit_msi" flag from powerpc to generic pci_dev

2014-10-01 Thread Benjamin Herrenschmidt
Some devices have broken 64-bit MSI support which only support some address bits (40 to 48 typically). This doesn't work on some platforms such as POWER servers, so we need a quirk. Currently we keep a flag in a powerpc specific data structure which we have per PCI device. However this is impract

[PATCH v2 1/4] pci/msi: Move "no_64bit_msi" flag from powerpc to generic pci_dev

2014-10-01 Thread Benjamin Herrenschmidt
Some devices have broken 64-bit MSI support which only support some address bits (40 to 48 typically). This doesn't work on some platforms such as POWER servers, so we need a quirk. Currently we keep a flag in a powerpc specific data structure which we have per PCI device. However this is impracti