Re: [PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables

2021-06-25 Thread Michael Ellerman
Christophe Leroy writes: > Le 25/06/2021 à 06:45, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> Hi Michael, >>> >>> Le 19/04/2021 à 12:47, Christophe Leroy a écrit : Pagewalk ignores hugepd entries and walk down the tables as if it was traditionnal entries, leading to crazy

Re: [PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables

2021-06-24 Thread Christophe Leroy
Le 25/06/2021 à 06:45, Michael Ellerman a écrit : Christophe Leroy writes: Hi Michael, Le 19/04/2021 à 12:47, Christophe Leroy a écrit : Pagewalk ignores hugepd entries and walk down the tables as if it was traditionnal entries, leading to crazy result. Add walk_hugepd_range() and use it

Re: [PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables

2021-06-24 Thread Michael Ellerman
Christophe Leroy writes: > Hi Michael, > > Le 19/04/2021 à 12:47, Christophe Leroy a écrit : >> Pagewalk ignores hugepd entries and walk down the tables >> as if it was traditionnal entries, leading to crazy result. >> >> Add walk_hugepd_range() and use it to walk hugepage tables. > > I see you t

Re: [PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables

2021-06-24 Thread Christophe Leroy
Hi Michael, Le 19/04/2021 à 12:47, Christophe Leroy a écrit : Pagewalk ignores hugepd entries and walk down the tables as if it was traditionnal entries, leading to crazy result. Add walk_hugepd_range() and use it to walk hugepage tables. I see you took patch 2 and 3 of the series. Do you ex

Re: [PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables

2021-04-19 Thread Steven Price
On 19/04/2021 11:47, Christophe Leroy wrote: Pagewalk ignores hugepd entries and walk down the tables as if it was traditionnal entries, leading to crazy result. Add walk_hugepd_range() and use it to walk hugepage tables. Signed-off-by: Christophe Leroy Looks correct to me, sadly I don't hav

[PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables

2021-04-19 Thread Christophe Leroy
Pagewalk ignores hugepd entries and walk down the tables as if it was traditionnal entries, leading to crazy result. Add walk_hugepd_range() and use it to walk hugepage tables. Signed-off-by: Christophe Leroy --- v2: - Add a guard for NULL ops->pte_entry - Take mm->page_table_lock when walking h