Re: [PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-27 Thread Wolfgang Grandegger
Ben Dooks wrote: > On Tue, Jan 26, 2010 at 07:44:10PM +0100, Wolfgang Grandegger wrote: >> Ben Dooks wrote: >>> On Mon, Jan 25, 2010 at 09:55:04PM +0100, Wolfgang Grandegger wrote: [snip] >>> Any particular reason you decided to move this all about? >> This was necessary to allow using __devinit[da

Re: [PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-27 Thread Ben Dooks
On Tue, Jan 26, 2010 at 07:44:10PM +0100, Wolfgang Grandegger wrote: > Ben Dooks wrote: > > On Mon, Jan 25, 2010 at 09:55:04PM +0100, Wolfgang Grandegger wrote: > >> From: Wolfgang Grandegger > >> > >> "__devinit[data]" has not yet been used for all initialization functions > >> and data. To avoid

Re: [PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-26 Thread Wolfgang Grandegger
Ben Dooks wrote: > On Mon, Jan 25, 2010 at 09:55:04PM +0100, Wolfgang Grandegger wrote: >> From: Wolfgang Grandegger >> >> "__devinit[data]" has not yet been used for all initialization functions >> and data. To avoid truncating lines, the struct mpc_i2c_match_data has >> been renamed to mpc_i2c_d

Re: [PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-26 Thread Ben Dooks
On Mon, Jan 25, 2010 at 09:55:04PM +0100, Wolfgang Grandegger wrote: > From: Wolfgang Grandegger > > "__devinit[data]" has not yet been used for all initialization functions > and data. To avoid truncating lines, the struct mpc_i2c_match_data has > been renamed to mpc_i2c_data, which is even the

[PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger --- drivers/i2c/busses/i2c-m