Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-21 Thread Helge Deller
On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-16 Thread Simona Vetter
On Fri, Dec 13, 2024 at 08:26:19AM +0100, Thomas Zimmermann wrote: > Hi > > > Am 13.12.24 um 00:56 schrieb Helge Deller: > > On 12/13/24 00:24, Jani Nikula wrote: > > > On Thu, 12 Dec 2024, "Arnd Bergmann" wrote: > > > > On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: > > > > > On 12/12/24 1

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Thomas Zimmermann
Hi Am 13.12.24 um 11:15 schrieb Christophe Leroy: Le 13/12/2024 à 09:41, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 09:33 schrieb Christophe Leroy: The attached patch selects backlight support in the defconfigs that also have PMAC_BACKLIGHT=y. Can you please apply it on top of the

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 09:41, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 09:33 schrieb Christophe Leroy: The attached patch selects backlight support in the defconfigs that also have PMAC_BACKLIGHT=y. Can you please apply it on top of the patchset and report on the results? That works

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 09:35, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 09:33 schrieb Christophe Leroy: Le 13/12/2024 à 09:05, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 08:44 schrieb Christophe Leroy: Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select BACKLIGHT_CLASS

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Thomas Zimmermann
Hi Am 13.12.24 um 09:33 schrieb Christophe Leroy: The attached patch selects backlight support in the defconfigs that also have PMAC_BACKLIGHT=y. Can you please apply it on top of the patchset and report on the results? That works for the defconfig but it is still possible to change C

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Thomas Zimmermann
Hi Am 13.12.24 um 09:33 schrieb Christophe Leroy: Le 13/12/2024 à 09:05, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 08:44 schrieb Christophe Leroy: Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls bac

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 09:05, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 08:44 schrieb Christophe Leroy: Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data struc

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Thomas Zimmermann
Hi Am 13.12.24 um 08:44 schrieb Christophe Leroy: Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DE

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Christophe Leroy
Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warni

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Thomas Zimmermann
Hi Am 13.12.24 um 00:56 schrieb Helge Deller: On 12/13/24 00:24, Jani Nikula wrote: On Thu, 12 Dec 2024, "Arnd Bergmann" wrote: On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Thomas Zimmermann
Hi Am 12.12.24 um 22:04 schrieb Arnd Bergmann: On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make f

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Helge Deller
On 12/13/24 00:24, Jani Nikula wrote: On Thu, 12 Dec 2024, "Arnd Bergmann" wrote: On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev cor

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, "Arnd Bergmann" wrote: > On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: >> On 12/12/24 11:04, Thomas Zimmermann wrote: >>> Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter >>> only controls backlight support within fbdev core code and data >>> structures

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Arnd Bergmann
On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: > On 12/12/24 11:04, Thomas Zimmermann wrote: >> Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter >> only controls backlight support within fbdev core code and data >> structures. >> >> Make fbdev drivers depend on BACKLIGHT_CLAS

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Helge Deller
On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about

[PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Thomas Zimmermann
Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about recursive dependencies, such as error: recurs