RE: [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock

2023-04-04 Thread Camelia Alexandra Groza
gt; Roy Pledge ; David S . Miller > ; Claudiu Manoil > Subject: Re: [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when > taking cgr_lock > > On 4/3/23 10:02, Vladimir Oltean wrote: > > On Fri, Mar 31, 2023 at 11:14:12AM -0400, Sean Anderson wrote: > >> smp

Re: [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock

2023-04-03 Thread Sean Anderson
On 4/3/23 10:02, Vladimir Oltean wrote: > On Fri, Mar 31, 2023 at 11:14:12AM -0400, Sean Anderson wrote: >> smp_call_function_single disables IRQs when executing the callback. To >> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere. >> This is already done by qman_update_cgr an

Re: [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock

2023-04-03 Thread Vladimir Oltean
On Fri, Mar 31, 2023 at 11:14:12AM -0400, Sean Anderson wrote: > smp_call_function_single disables IRQs when executing the callback. To > prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere. > This is already done by qman_update_cgr and qman_delete_cgr; fix the > other lockers. >

[PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock

2023-03-31 Thread Sean Anderson
smp_call_function_single disables IRQs when executing the callback. To prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere. This is already done by qman_update_cgr and qman_delete_cgr; fix the other lockers. Fixes: c535e923bb97 ("soc/fsl: Introduce DPAA 1.x QMan device driver")