RE: [PATCH v2 09/10] RapidIO: Add support for IDT CPS Gen2 switches

2010-09-15 Thread Anderson, Trevor
v2 09/10] RapidIO: Add support for IDT CPS Gen2 switches > > Anderson, Trevor wrote: > > > > Keep it in please. We lurkers in the embedded community do use the > per-port routing tables. > > One of the problems with SRIO switch tables is that access to routes > is not

RE: [PATCH v2 09/10] RapidIO: Add support for IDT CPS Gen2 switches

2010-09-15 Thread Bounine, Alexandre
Anderson, Trevor wrote: > > Keep it in please. We lurkers in the embedded community do use the per-port routing tables. > One of the problems with SRIO switch tables is that access to routes is not atomic; we can use > restricted access to per-port routing tables to reduce the risk of interferenc

RE: [PATCH v2 09/10] RapidIO: Add support for IDT CPS Gen2 switches

2010-09-15 Thread Anderson, Trevor
2010 8:31 AM > To: Andrew Morton > Cc: linux-ker...@vger.kernel.org; Thomas Moll; linuxppc-dev@lists.ozlabs.org > Subject: RE: [PATCH v2 09/10] RapidIO: Add support for IDT CPS Gen2 switches > > Andrew Morton wrote: > > > The handling of `table' is strange. One

RE: [PATCH v2 09/10] RapidIO: Add support for IDT CPS Gen2 switches

2010-09-15 Thread Bounine, Alexandre
Andrew Morton wrote: > The handling of `table' is strange. One would expect the caller of > this function to provide the correct table index, and for the caller to > increment that index at an appropriate time. Handling of the 'table' parameter is hardware-dependent. RIO switches (at least all

Re: [PATCH v2 09/10] RapidIO: Add support for IDT CPS Gen2 switches

2010-09-14 Thread Andrew Morton
On Tue, 14 Sep 2010 10:59:22 -0400 Alexandre Bounine wrote: > +static int > +idtg2_route_add_entry(struct rio_mport *mport, u16 destid, u8 hopcount, > +u16 table, u16 route_destid, u8 route_port) > +{ > + /* > + * Select routing table to update > + */ > + if

[PATCH v2 09/10] RapidIO: Add support for IDT CPS Gen2 switches

2010-09-14 Thread Alexandre Bounine
Add the RIO switch driver and definitions for IDT CPS-1848 and CPS-1616 Gen2 devices. Signed-off-by: Alexandre Bounine Cc: Thomas Moll Cc: Matt Porter Cc: Li Yang Cc: Kumar Gala Cc: Micha Nelissen --- drivers/rapidio/switches/Kconfig|7 + drivers/rapidio/switches/Makefile |1 +