Re: [PATCH v2 07/14] of/reconfig: Always use the same structure for notifiers

2014-11-26 Thread Grant Likely
On Tue, 25 Nov 2014 21:11:58 -0600 , Nathan Fontenot wrote: > On 11/25/2014 05:07 PM, Benjamin Herrenschmidt wrote: > > On Mon, 2014-11-24 at 22:33 +, Grant Likely wrote: > >> The OF_RECONFIG notifier callback uses a different structure depending > >> on whether it is a node change or a prope

Re: [PATCH v2 07/14] of/reconfig: Always use the same structure for notifiers

2014-11-25 Thread Nathan Fontenot
On 11/25/2014 05:07 PM, Benjamin Herrenschmidt wrote: > On Mon, 2014-11-24 at 22:33 +, Grant Likely wrote: >> The OF_RECONFIG notifier callback uses a different structure depending >> on whether it is a node change or a property change. This is silly, and >> not very safe. Rework the code to us

Re: [PATCH v2 07/14] of/reconfig: Always use the same structure for notifiers

2014-11-25 Thread Benjamin Herrenschmidt
On Mon, 2014-11-24 at 22:33 +, Grant Likely wrote: > The OF_RECONFIG notifier callback uses a different structure depending > on whether it is a node change or a property change. This is silly, and > not very safe. Rework the code to use the same data structure regardless > of the type of notif

[PATCH v2 07/14] of/reconfig: Always use the same structure for notifiers

2014-11-24 Thread Grant Likely
The OF_RECONFIG notifier callback uses a different structure depending on whether it is a node change or a property change. This is silly, and not very safe. Rework the code to use the same data structure regardless of the type of notifier. Signed-off-by: Grant Likely Cc: Benjamin Herrenschmidt