Re: [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it

2023-12-06 Thread George Stark
Hello Christophe Thanks for the review On 12/5/23 02:09, Christophe Leroy wrote: Le 04/12/2023 à 19:05, George Stark a écrit : In the probe() callback in case of error mutex is destroyed being locked which is not allowed so unlock the mute before destroying. Should there be a fixes: tag ?

Re: [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it

2023-12-04 Thread Christophe Leroy
Le 04/12/2023 à 19:05, George Stark a écrit : > In the probe() callback in case of error mutex is destroyed being locked > which is not allowed so unlock the mute before destroying. Should there be a fixes: tag ? For instance on 59ea3c9faf32 ("leds: add aw2013 driver") ? > > Signed-off-by: Ge

Re: [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it

2023-12-04 Thread Andy Shevchenko
On Mon, Dec 4, 2023 at 8:07 PM George Stark wrote: > > In the probe() callback in case of error mutex is destroyed being locked > which is not allowed so unlock the mute before destroying. Sounds to me like this is a real fix, hence the Fixes tag and being first in the series. You free to add Re

[PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it

2023-12-04 Thread George Stark
In the probe() callback in case of error mutex is destroyed being locked which is not allowed so unlock the mute before destroying. Signed-off-by: George Stark --- drivers/leds/leds-aw2013.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013