Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

2025-02-06 Thread Zheng Yejian
On 2025/1/22 01:48, Steven Rostedt wrote: Sorry for the late reply. Forgot about this as I was focused on other end-of-year issues. On Sat, 14 Dec 2024 16:37:59 +0800 Zheng Yejian wrote: The direct cause of this issue is the wrong fentry being founded by ftrace_location(), following the ap

Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

2025-01-21 Thread Steven Rostedt
Sorry for the late reply. Forgot about this as I was focused on other end-of-year issues. On Sat, 14 Dec 2024 16:37:59 +0800 Zheng Yejian wrote: > The direct cause of this issue is the wrong fentry being founded by > ftrace_location(), > following the approach of "FTRACE_MCOUNT_MAX_OFFSET",

Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

2024-12-14 Thread Zheng Yejian
On 2024/12/14 03:31, Martin Kelly wrote: On Thu, 2024-12-12 at 17:52 +0800, Zheng Yejian wrote: On 2024/12/11 04:49, Martin Kelly wrote: Zheng, do you plan to send a v3? I'd be happy to help out with this patch series if you'd like, as I'm hoping to get this issue resolved (though I am not an

Re: Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

2024-12-13 Thread Martin Kelly
On Thu, 2024-12-12 at 17:52 +0800, Zheng Yejian wrote: > On 2024/12/11 04:49, Martin Kelly wrote: > > > > > > Zheng, do you plan to send a v3? I'd be happy to help out with this > > patch series if you'd like, as I'm hoping to get this issue > > resolved > > (though I am not an ftrace expert). >

Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

2024-12-12 Thread Zheng Yejian
On 2024/12/11 04:49, Martin Kelly wrote: On Tue, 2024-12-10 at 21:01 +0100, Christophe Leroy wrote: Hi all, what is the status of this patch series? I'd really like to see it or some other fix to this issue merged. The underlying bug is a significant one that can cause ftrace/livepatch/BPF fent

Re: Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

2024-12-10 Thread Martin Kelly
On Tue, 2024-12-10 at 21:01 +0100, Christophe Leroy wrote: > > > > Hi all, what is the status of this patch series? I'd really like to > > see > > it or some other fix to this issue merged. The underlying bug is a > > significant one that can cause ftrace/livepatch/BPF fentry to fail > > silently.

Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

2024-12-10 Thread Martin Kelly
On Tue, 2024-07-23 at 14:32 +0800, Zheng Yejian wrote: > Background of this patch set can be found in v1: > > https://lore.kernel.org/all/20240613133711.2867745-1-zhengyeji...@huawei.com/ >   > > Here add a reproduction to show the impact to livepatch: > 1. Add following hack to make livepatch-sa

Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

2024-12-10 Thread Christophe Leroy
Hi, Le 10/12/2024 à 20:15, Martin Kelly a écrit : [Vous ne recevez pas souvent de courriers de martin.ke...@crowdstrike.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] On Tue, 2024-07-23 at 14:32 +0800, Zheng Yejian wrote: Background of this patch

[PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

2024-07-23 Thread Zheng Yejian
Background of this patch set can be found in v1: https://lore.kernel.org/all/20240613133711.2867745-1-zhengyeji...@huawei.com/ Here add a reproduction to show the impact to livepatch: 1. Add following hack to make livepatch-sample.ko do patch on do_one_initcall() which has an overriden weak fun