Re: [PATCH v2] workqueue: Fix edge cases for calc of pool's cpumask

2017-06-06 Thread Michael Bringmann
On 06/06/2017 09:20 AM, Tejun Heo wrote: > Hello, Michael. > > It would have been better to continue debugging in the prev thread. > This still seems incorrect for the same reason as before. > > On Tue, Jun 06, 2017 at 09:09:40AM -0500, Michael Bringmann wrote: >> On NUMA systems with dynamic p

Re: [PATCH v2] workqueue: Fix edge cases for calc of pool's cpumask

2017-06-06 Thread Tejun Heo
Hello, On Tue, Jun 06, 2017 at 09:34:05AM -0500, Michael Bringmann wrote: > >> diff --git a/kernel/workqueue.c b/kernel/workqueue.c > >> index c74bf39..460de61 100644 > >> --- a/kernel/workqueue.c > >> +++ b/kernel/workqueue.c > >> @@ -3366,6 +3366,9 @@ static struct worker_pool *get_unbound_pool(

Re: [PATCH v2] workqueue: Fix edge cases for calc of pool's cpumask

2017-06-06 Thread Tejun Heo
Hello, Michael. It would have been better to continue debugging in the prev thread. This still seems incorrect for the same reason as before. On Tue, Jun 06, 2017 at 09:09:40AM -0500, Michael Bringmann wrote: > On NUMA systems with dynamic processors, the content of the cpumask > may change over

[PATCH v2] workqueue: Fix edge cases for calc of pool's cpumask

2017-06-06 Thread Michael Bringmann
On NUMA systems with dynamic processors, the content of the cpumask may change over time. As new processors are added via DLPAR operations, workqueues are created for them. Depending upon the order in which CPUs are added/removed, we may run into problems with the content of the cpumask used by