Re: [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-07 Thread Michael Ellerman
Finn Thain writes: > On Fri, 5 Apr 2024, Michael Ellerman wrote: > >> I assume you have tested this on an actual pmac, as well as qemu? >> > > I tested the patched driver and its console functionality using Zilog SCC > hardware in a Mac IIci, as well as QEMU's q800 virtual machine. > > That shou

Re: [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-05 Thread Finn Thain
On Fri, 5 Apr 2024, Michael Ellerman wrote: > I assume you have tested this on an actual pmac, as well as qemu? > I tested the patched driver and its console functionality using Zilog SCC hardware in a Mac IIci, as well as QEMU's q800 virtual machine. That should suffice from a code coverage p

Re: [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Michael Ellerman
Finn Thain writes: > The mitigation was intended to stop the irq completely. That may be > better than a hard lock-up but it turns out that you get a crash anyway > if you're using pmac_zilog as a serial console: > > ttyPZ0: pmz: rx irq flood ! > BUG: spinlock recursion on CPU#0, swapper/0 > > Tha

[PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Finn Thain
The mitigation was intended to stop the irq completely. That may be better than a hard lock-up but it turns out that you get a crash anyway if you're using pmac_zilog as a serial console: ttyPZ0: pmz: rx irq flood ! BUG: spinlock recursion on CPU#0, swapper/0 That's because the pr_err() call in p