Re: [PATCH v2] sched/membarrier: Fix redundant load of membarrier_state

2025-01-09 Thread Michal Hocko
On Mon 18-11-24 10:25:17, Peter Zijlstra wrote: > On Mon, Nov 18, 2024 at 10:04:18AM +0100, Michal Hocko wrote: > > I do not see this patch staged in any tree (e.g. linux-next). Is this on > > its way to be merged? > > I only now found it -- it doesn't look super urgent. I'll get it into a > git t

Re: [PATCH v2] sched/membarrier: Fix redundant load of membarrier_state

2024-11-18 Thread Peter Zijlstra
On Mon, Nov 18, 2024 at 10:04:18AM +0100, Michal Hocko wrote: > I do not see this patch staged in any tree (e.g. linux-next). Is this on > its way to be merged? I only now found it -- it doesn't look super urgent. I'll get it into a git tree after -rc1.

Re: [PATCH v2] sched/membarrier: Fix redundant load of membarrier_state

2024-11-18 Thread Michal Hocko
On Mon 18-11-24 10:25:17, Peter Zijlstra wrote: > On Mon, Nov 18, 2024 at 10:04:18AM +0100, Michal Hocko wrote: > > I do not see this patch staged in any tree (e.g. linux-next). Is this on > > its way to be merged? > > I only now found it -- it doesn't look super urgent. I'll get it into a > git t

Re: [PATCH v2] sched/membarrier: Fix redundant load of membarrier_state

2024-11-18 Thread Michal Hocko
I do not see this patch staged in any tree (e.g. linux-next). Is this on its way to be merged? Thanks! On Tue 29-10-24 11:21:28, Nysal Jan K.A. wrote: > On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > is not selected, sync_core_before_usermode() is a no-op. > In membarrier_mm_sync_cor

Re: [PATCH v2] sched/membarrier: Fix redundant load of membarrier_state

2024-10-30 Thread Segher Boessenkool
Hi! On Tue, Oct 29, 2024 at 11:21:28AM +0530, Nysal Jan K.A. wrote: > On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > is not selected, sync_core_before_usermode() is a no-op. > In membarrier_mm_sync_core_before_usermode() the compiler does not > eliminate redundant branches and load of

Re: [PATCH v2] sched/membarrier: Fix redundant load of membarrier_state

2024-10-29 Thread Michael Ellerman
"Nysal Jan K.A." writes: > On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > is not selected, sync_core_before_usermode() is a no-op. > In membarrier_mm_sync_core_before_usermode() the compiler does not > eliminate redundant branches and load of mm->membarrier_state > for this case as th

Re: [PATCH v2] sched/membarrier: Fix redundant load of membarrier_state

2024-10-29 Thread Mathieu Desnoyers
On 2024-10-29 01:51, Nysal Jan K.A. wrote: On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE is not selected, sync_core_before_usermode() is a no-op. In membarrier_mm_sync_core_before_usermode() the compiler does not eliminate redundant branches and load of mm->membarrier_state for this c

[PATCH v2] sched/membarrier: Fix redundant load of membarrier_state

2024-10-28 Thread Nysal Jan K.A.
On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE is not selected, sync_core_before_usermode() is a no-op. In membarrier_mm_sync_core_before_usermode() the compiler does not eliminate redundant branches and load of mm->membarrier_state for this case as the atomic_read() cannot be optimized