Re: [PATCH v2] qe_lib: Set gpio data before changing the direction to output

On Aug 18, 2009, at 4:20 PM, Michael Barkowski wrote: This avoids having a short glitch if the desired initial value is not the same as what was previously in the data register. Signed-off-by: Michael Barkowski --- Anton Vorontsov wrote: There is a recursive locking bug: _set() takes the sam

Re: [PATCH v2] qe_lib: Set gpio data before changing the direction to output

On Wed, Aug 19, 2009 at 09:30:20AM -0400, Michael Barkowski wrote: > Anton Vorontsov wrote: > > On Tue, Aug 18, 2009 at 05:33:00PM -0500, Timur Tabi wrote: > >> Anton Vorontsov wrote: > >>> On Tue, Aug 18, 2009 at 05:20:44PM -0400, Michael Barkowski wrote: > This avoids having a short glitch i

Re: [PATCH v2] qe_lib: Set gpio data before changing the direction to output

Anton Vorontsov wrote: > On Tue, Aug 18, 2009 at 05:33:00PM -0500, Timur Tabi wrote: >> Anton Vorontsov wrote: >>> On Tue, Aug 18, 2009 at 05:20:44PM -0400, Michael Barkowski wrote: This avoids having a short glitch if the desired initial value is not the same as what was previously in th

Re: [PATCH v2] qe_lib: Set gpio data before changing the direction to output

On Tue, Aug 18, 2009 at 05:33:00PM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: > > On Tue, Aug 18, 2009 at 05:20:44PM -0400, Michael Barkowski wrote: > >> This avoids having a short glitch if the desired initial value is not > >> the same as what was previously in the data register. > >> > >>

Re: [PATCH v2] qe_lib: Set gpio data before changing the direction to output

Anton Vorontsov wrote: > On Tue, Aug 18, 2009 at 05:20:44PM -0400, Michael Barkowski wrote: >> This avoids having a short glitch if the desired initial value is not >> the same as what was previously in the data register. >> >> Signed-off-by: Michael Barkowski > > Acked-by: Anton Vorontsov I do

Re: [PATCH v2] qe_lib: Set gpio data before changing the direction to output

On Tue, Aug 18, 2009 at 05:20:44PM -0400, Michael Barkowski wrote: > This avoids having a short glitch if the desired initial value is not > the same as what was previously in the data register. > > Signed-off-by: Michael Barkowski Acked-by: Anton Vorontsov Thanks! > --- > Anton Vorontsov wro

[PATCH v2] qe_lib: Set gpio data before changing the direction to output

This avoids having a short glitch if the desired initial value is not the same as what was previously in the data register. Signed-off-by: Michael Barkowski --- Anton Vorontsov wrote: > There is a recursive locking bug: _set() takes the same spinlock. > So you'd better move this call two lines up