Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-25 Thread Scott Wood
On Fri, Sep 19, 2008 at 05:11:15PM +0200, Peter Korsgaard wrote: > Anton> This is purposely. We also need support for 8610, and maybe > Anton> later we'll find another chip with the same unit. So, to not touch > Anton> the Kconfig for every new chip I just made it PPC32-wide. Other > Anton> opt

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-25 Thread Scott Wood
On Fri, Sep 19, 2008 at 01:46:49PM -0500, Kumar Gala wrote: > You are correct we try to avoid this, but than I suggest we do it by > family. I think its confusing to show 8610 and 8349 in the same dev > tree. I don't think it's confusing (at least, not moreso than picking an arbitrary chip wi

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-21 Thread Peter Korsgaard
> "Kumar" == Kumar Gala <[EMAIL PROTECTED]> writes: Hi, Kumar> This way the compatiable binding in the code just lists something like Kumar> "fsl,mpc8349-gpio", "fsl,mpc8610-gpio", "fsl,mpc8572-gpio". Kumar> Does that make sense? Yes, sounds fine - I'll adapt the patch and resend. -- B

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-19 Thread Kumar Gala
On Sep 19, 2008, at 1:12 PM, Anton Vorontsov wrote: On Fri, Sep 19, 2008 at 01:02:11PM -0500, Kumar Gala wrote: [...] Anton> This is purposely. We also need support for 8610, and maybe Anton> later we'll find another chip with the same unit. So, to not touch Anton> the Kconfig for every new ch

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-19 Thread Anton Vorontsov
On Fri, Sep 19, 2008 at 01:02:11PM -0500, Kumar Gala wrote: [...] >>> Anton> This is purposely. We also need support for 8610, and maybe >>> Anton> later we'll find another chip with the same unit. So, to not >>> touch >>> Anton> the Kconfig for every new chip I just made it PPC32-wide. >>> Oth

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-19 Thread Kumar Gala
On Sep 19, 2008, at 10:33 AM, Anton Vorontsov wrote: On Fri, Sep 19, 2008 at 05:11:15PM +0200, Peter Korsgaard wrote: "Anton" == Anton Vorontsov <[EMAIL PROTECTED]> writes: Hi, It seems basically the same as my patch (gpio driver for mpc831x/mpc834x/mpc837x with OF bindings) from September

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-19 Thread Anton Vorontsov
On Fri, Sep 19, 2008 at 05:11:15PM +0200, Peter Korsgaard wrote: > > "Anton" == Anton Vorontsov <[EMAIL PROTECTED]> writes: > > Hi, > > >> It seems basically the same as my patch (gpio driver for > >> mpc831x/mpc834x/mpc837x with OF bindings) from September 5th except > >> you don't have a

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-19 Thread Peter Korsgaard
> "Anton" == Anton Vorontsov <[EMAIL PROTECTED]> writes: Hi, >> It seems basically the same as my patch (gpio driver for >> mpc831x/mpc834x/mpc837x with OF bindings) from September 5th except >> you don't have any documentation Anton> Well, do we really need documentation for every trivi

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-18 Thread Anton Vorontsov
On Wed, Sep 17, 2008 at 09:30:16PM +0200, Peter Korsgaard wrote: > > "Anton" == Anton Vorontsov <[EMAIL PROTECTED]> writes: > > Hi, > > Anton> This patch implements GPIOLIB support for MPC8349-compatible SOC > GPIOs. > Anton> MPC8610 adopted this GPIO unit, so let's place it into sysdev. >

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-17 Thread Peter Korsgaard
> "Anton" == Anton Vorontsov <[EMAIL PROTECTED]> writes: Hi, Anton> This patch implements GPIOLIB support for MPC8349-compatible SOC GPIOs. Anton> MPC8610 adopted this GPIO unit, so let's place it into sysdev. Anton> We'll need these gpios to support IrDA transceiver on MPC8610HPCD. It s

[PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-17 Thread Anton Vorontsov
This patch implements GPIOLIB support for MPC8349-compatible SOC GPIOs. MPC8610 adopted this GPIO unit, so let's place it into sysdev. We'll need these gpios to support IrDA transceiver on MPC8610HPCD. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- v2: - Incorporated Peter Korsgaard's su