Re: [PATCH v2] powerpc: Remove eieio() in PowerPC IO functions

2025-01-31 Thread Arnd Bergmann
On Wed, Jan 29, 2025, at 12:14, Segher Boessenkool wrote: > On Wed, Jan 29, 2025 at 10:45:10AM +0100, Julian Vetter wrote: >> Remove the eieio() calls in IO functions for PowerPC. While other >> architectures permit prefetching, combining, and reordering, the eieio() >> calls on PowerPC prevent suc

Re: [PATCH v2] powerpc: Remove eieio() in PowerPC IO functions

2025-01-29 Thread Julian Vetter
On 29.01.25 12:14, Segher Boessenkool wrote: On Wed, Jan 29, 2025 at 10:45:10AM +0100, Julian Vetter wrote: Remove the eieio() calls in IO functions for PowerPC. While other architectures permit prefetching, combining, and reordering, the eieio() calls on PowerPC prevent such optimizations. Ye

Re: [PATCH v2] powerpc: Remove eieio() in PowerPC IO functions

2025-01-29 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 10:45:10AM +0100, Julian Vetter wrote: > Remove the eieio() calls in IO functions for PowerPC. While other > architectures permit prefetching, combining, and reordering, the eieio() > calls on PowerPC prevent such optimizations. Yes, and it is crucial to prevent combining,

[PATCH v2] powerpc: Remove eieio() in PowerPC IO functions

2025-01-29 Thread Julian Vetter
Remove the eieio() calls in IO functions for PowerPC. While other architectures permit prefetching, combining, and reordering, the eieio() calls on PowerPC prevent such optimizations. This has only historical reasons, because in the early arch/powerpc64 code also readl() had these eieio() calls, bu