Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-23 Thread Kamalesh Babulal
On Saturday 21 October 2017 06:29 AM, Balbir Singh wrote: On Fri, 2017-10-20 at 14:07 +0200, Torsten Duwe wrote: On Wed, Oct 18, 2017 at 11:47:35AM +0530, Kamalesh Babulal wrote: Consider a trivial patch, supplied to kpatch tool for generating a livepatch module: --- a/fs/proc/meminfo.c +++ b

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-20 Thread Balbir Singh
On Fri, 2017-10-20 at 14:07 +0200, Torsten Duwe wrote: > On Wed, Oct 18, 2017 at 11:47:35AM +0530, Kamalesh Babulal wrote: > > > > Consider a trivial patch, supplied to kpatch tool for generating a > > livepatch module: > > > > --- a/fs/proc/meminfo.c > > +++ b/fs/proc/meminfo.c > > @@ -132,7 +13

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-20 Thread Torsten Duwe
On Wed, Oct 18, 2017 at 11:47:35AM +0530, Kamalesh Babulal wrote: > > Consider a trivial patch, supplied to kpatch tool for generating a > livepatch module: > > --- a/fs/proc/meminfo.c > +++ b/fs/proc/meminfo.c > @@ -132,7 +132,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v) >

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-17 Thread Kamalesh Babulal
On Tuesday 17 October 2017 08:17 PM, Torsten Duwe wrote: > On Fri, Oct 06, 2017 at 11:27:42AM +0530, Kamalesh Babulal wrote: >> >> Consider the livepatch sequence[1]. Where function A calls B, B is the >> function which has been livepatched and the call to function B is >> redirected to patched ver

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-17 Thread Torsten Duwe
On Fri, Oct 06, 2017 at 11:27:42AM +0530, Kamalesh Babulal wrote: > > Consider the livepatch sequence[1]. Where function A calls B, B is the > function which has been livepatched and the call to function B is > redirected to patched version P. P calls the function C in M2, whereas > C was local to

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-11 Thread Kamalesh Babulal
On Friday 06 October 2017 11:13 AM, Kamalesh Babulal wrote: On Thursday 05 October 2017 06:13 PM, Torsten Duwe wrote: On Wed, Oct 04, 2017 at 11:25:16AM -0400, Kamalesh Babulal wrote: Both the failures with REL24 livepatch symbols relocation, can be resolved by constructing a new livepatch stu

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-05 Thread Kamalesh Babulal
On Thursday 05 October 2017 06:13 PM, Torsten Duwe wrote: On Wed, Oct 04, 2017 at 11:25:16AM -0400, Kamalesh Babulal wrote: Both the failures with REL24 livepatch symbols relocation, can be resolved by constructing a new livepatch stub. The newly setup klp_stub mimics the functionality of entry

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-05 Thread Kamalesh Babulal
On Thursday 05 October 2017 06:13 PM, Torsten Duwe wrote: On Wed, Oct 04, 2017 at 11:25:16AM -0400, Kamalesh Babulal wrote: Both the failures with REL24 livepatch symbols relocation, can be resolved by constructing a new livepatch stub. The newly setup klp_stub mimics the functionality of entry

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-05 Thread Torsten Duwe
On Wed, Oct 04, 2017 at 11:25:16AM -0400, Kamalesh Babulal wrote: > > Both the failures with REL24 livepatch symbols relocation, can be > resolved by constructing a new livepatch stub. The newly setup klp_stub > mimics the functionality of entry_64.S::livepatch_handler introduced by > commit 85baa

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-04 Thread Naveen N . Rao
On 2017/10/04 03:25PM, Kamalesh Babulal wrote: > With commit 425595a7fc20 ("livepatch: reuse module loader code to > write relocations") livepatch uses module loader to write relocations > of livepatch symbols, instead of managing them by arch-dependent > klp_write_module_reloc() function. > > liv

[PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-04 Thread Kamalesh Babulal
With commit 425595a7fc20 ("livepatch: reuse module loader code to write relocations") livepatch uses module loader to write relocations of livepatch symbols, instead of managing them by arch-dependent klp_write_module_reloc() function. livepatch module managed relocation entries are written to sec