Re: [PATCH v2] cxl: Add explicit precision specifiers

2015-02-23 Thread Ian Munsie
Excerpts from Joe Perches's message of 2015-02-24 01:59:45 +1100: > On Mon, 2015-02-23 at 11:55 +0100, Rasmus Villemoes wrote: > > 24 of the %.16llx > > matches are in drivers/misc/cxl/, so internal consistency wins. > > I think that's more an argument for changing all of the > cx1 uses to "%016ll

Re: [PATCH v2] cxl: Add explicit precision specifiers

2015-02-23 Thread Ian Munsie
Acked-by: Ian Munsie ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] cxl: Add explicit precision specifiers

2015-02-23 Thread Michael Ellerman
On Mon, 2015-02-23 at 06:59 -0800, Joe Perches wrote: > On Mon, 2015-02-23 at 11:55 +0100, Rasmus Villemoes wrote: > > 24 of the %.16llx > > matches are in drivers/misc/cxl/, so internal consistency wins. > > I think that's more an argument for changing all of the > cx1 uses to "%016llx". +1 che

Re: [PATCH v2] cxl: Add explicit precision specifiers

2015-02-23 Thread Joe Perches
On Mon, 2015-02-23 at 11:55 +0100, Rasmus Villemoes wrote: > 24 of the %.16llx > matches are in drivers/misc/cxl/, so internal consistency wins. I think that's more an argument for changing all of the cx1 uses to "%016llx". ___ Linuxppc-dev mailing lis

[PATCH v2] cxl: Add explicit precision specifiers

2015-02-23 Thread Rasmus Villemoes
C99 says that a precision given as simply '.' with no following digits or * should be interpreted as 0. The kernel's printf implementation, however, treats this case as if the precision was omitted. C99 also says that if both the precision and value are 0, no digits should be printed. Even if the k