RE: [PATCH v2] arm64: kexec: Check if IRQ is already masked before masking

2024-11-28 Thread Farber, Eliav
On 11/28/2024 12:39 PM, Thomas Gleixner wrote: > This is just wrong. If the interrupt was torn down, then its state is > deactivated and it was masked already. So the EOI handling and the > mask/disable dance are neither required nor make sense. > > So this whole thing should be: > >

Re: [PATCH v2] arm64: kexec: Check if IRQ is already masked before masking

2024-11-28 Thread Thomas Gleixner
On Wed, Nov 27 2024 at 15:22, Eliav Farber wrote: As a related note. The subject line is not really matching what the patch does. It want's to be split into a core change and one patch per architecture. > This patch replaces the direct invocation of the irq_mask() and git grep 'This patch' Docum

Re: [PATCH v2] arm64: kexec: Check if IRQ is already masked before masking

2024-11-28 Thread Thomas Gleixner
On Wed, Nov 27 2024 at 15:22, Eliav Farber wrote: > diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c > index 80ceb5bd2680..54d0bd1bd449 100644 > --- a/arch/arm/kernel/machine_kexec.c > +++ b/arch/arm/kernel/machine_kexec.c > @@ -142,11 +142,8 @@ static void machine_kex

[PATCH v2] arm64: kexec: Check if IRQ is already masked before masking

2024-11-27 Thread Eliav Farber
During machine kexec, the function machine_kexec_mask_interrupts() is responsible for disabling or masking all interrupts. While the irq_disable hook ensures that an already-disabled IRQ is not disabled again, the current implementation unconditionally invokes the irq_mask() function for every inte