>+ msi_mask = of_get_property(dev->dev.of_node, "msi-mask", NULL);
> >+ if (!msi_mask) {
> >+ err = -1;
> >+ goto error_out;
> >+ }
>
> This will return non zero value to probe function which would call
ppc4xx_msi_remove() function. In the ppc4xx_msi_remove(
On Mon, Nov 29, 2
>
> >
> > My apologies in the delay here. I was on holiday for a while and never
> > got back to review this. A few notes below.
> >
> > Also, I've added a few patches from Victor for suspend/idle support in
> > my next branch that cause a minor conflict with this one. It's not
On Mon, 2010-11-29 at 13:35 -0500, Josh Boyer wrote:
> On Mon, Nov 15, 2010 at 12:15:06PM -0800, tma...@apm.com wrote:
> >From: Tirumala Marri
> >
> >This patch adds MSI support for 440SPe, 460Ex, 460Sx and 405Ex.
> >
>
> My apologies in the delay here. I was on holiday for a while and never
> g
On Mon, Nov 15, 2010 at 12:15:06PM -0800, tma...@apm.com wrote:
>From: Tirumala Marri
>
>This patch adds MSI support for 440SPe, 460Ex, 460Sx and 405Ex.
>
My apologies in the delay here. I was on holiday for a while and never
got back to review this. A few notes below.
Also, I've added a few p
From: Tirumala Marri
This patch adds MSI support for 440SPe, 460Ex, 460Sx and 405Ex.
Signed-off-by: Tirumala R Marri
---
v1:
* Get rid of bitmap functions.
* Remove irq mapping as each MSI is tied to UIC.
* Cleaning up of prints.
v2:
* Remove or add blank lines at appropriate places.
