Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-08-02 Thread Amit Machhiwal
Hi Stefan, On 2024/07/29 03:27 PM, Stefan Bader wrote: > On 26.07.24 13:37, Rob Herring wrote: > > + Ubuntu kernel list, again > > > > On Thu, Jul 25, 2024 at 11:15:39PM +0530, Amit Machhiwal wrote: > > > Hi Lizhi, Rob, > > > > > > Sorry for responding late. I got busy with some other things. >

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-29 Thread Stefan Bader
On 26.07.24 13:37, Rob Herring wrote: + Ubuntu kernel list, again On Thu, Jul 25, 2024 at 11:15:39PM +0530, Amit Machhiwal wrote: Hi Lizhi, Rob, Sorry for responding late. I got busy with some other things. On 2024/07/23 02:08 PM, Lizhi Hou wrote: On 7/23/24 12:54, Rob Herring wrote: On Tu

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-29 Thread Lizhi Hou
On 7/29/24 09:55, Amit Machhiwal wrote: Hi Lizhi, On 2024/07/29 09:47 AM, Lizhi Hou wrote: Hi Amit On 7/29/24 04:13, Amit Machhiwal wrote: Hi Lizhi, On 2024/07/26 11:45 AM, Lizhi Hou wrote: On 7/26/24 10:52, Rob Herring wrote: On Thu, Jul 25, 2024 at 6:06 PM Lizhi Hou wrote: Hi Amit,

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-29 Thread Amit Machhiwal
Hi Lizhi, On 2024/07/29 09:47 AM, Lizhi Hou wrote: > Hi Amit > > On 7/29/24 04:13, Amit Machhiwal wrote: > > Hi Lizhi, > > > > On 2024/07/26 11:45 AM, Lizhi Hou wrote: > > > On 7/26/24 10:52, Rob Herring wrote: > > > > On Thu, Jul 25, 2024 at 6:06 PM Lizhi Hou wrote: > > > > > Hi Amit, > > > >

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-29 Thread Lizhi Hou
Hi Amit On 7/29/24 04:13, Amit Machhiwal wrote: Hi Lizhi, On 2024/07/26 11:45 AM, Lizhi Hou wrote: On 7/26/24 10:52, Rob Herring wrote: On Thu, Jul 25, 2024 at 6:06 PM Lizhi Hou wrote: Hi Amit, I try to follow the option which add a OF flag. If Rob is ok with this, I would suggest to use

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-29 Thread Amit Machhiwal
Hi Lizhi, On 2024/07/26 11:45 AM, Lizhi Hou wrote: > > On 7/26/24 10:52, Rob Herring wrote: > > On Thu, Jul 25, 2024 at 6:06 PM Lizhi Hou wrote: > > > Hi Amit, > > > > > > > > > I try to follow the option which add a OF flag. If Rob is ok with this, > > > I would suggest to use it instead of V

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-26 Thread Lizhi Hou
On 7/26/24 10:52, Rob Herring wrote: On Thu, Jul 25, 2024 at 6:06 PM Lizhi Hou wrote: Hi Amit, I try to follow the option which add a OF flag. If Rob is ok with this, I would suggest to use it instead of V1 patch diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c index dda6092e6d3a..

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-26 Thread Rob Herring
On Thu, Jul 25, 2024 at 6:06 PM Lizhi Hou wrote: > > Hi Amit, > > > I try to follow the option which add a OF flag. If Rob is ok with this, > I would suggest to use it instead of V1 patch > > diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c > index dda6092e6d3a..a401ed0463d9 100644 > --- a

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-26 Thread Michael Ellerman
Amit Machhiwal writes: > Hi Bjorn, > > On 2024/07/25 03:55 PM, Bjorn Helgaas wrote: >> On Thu, Jul 25, 2024 at 11:15:39PM +0530, Amit Machhiwal wrote: >> > ... >> > The crash in question is a critical issue that we would want to have >> > a fix for soon. And while this is still being figured out,

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-26 Thread Rob Herring
+ Ubuntu kernel list, again On Thu, Jul 25, 2024 at 11:15:39PM +0530, Amit Machhiwal wrote: > Hi Lizhi, Rob, > > Sorry for responding late. I got busy with some other things. > > On 2024/07/23 02:08 PM, Lizhi Hou wrote: > > > > On 7/23/24 12:54, Rob Herring wrote: > > > On Tue, Jul 23, 2024 at

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-25 Thread Amit Machhiwal
Hi Bjorn, On 2024/07/25 03:55 PM, Bjorn Helgaas wrote: > On Thu, Jul 25, 2024 at 11:15:39PM +0530, Amit Machhiwal wrote: > > ... > > The crash in question is a critical issue that we would want to have > > a fix for soon. And while this is still being figured out, is it > > okay to go with the fix

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-25 Thread Lizhi Hou
Hi Amit, I try to follow the option which add a OF flag. If Rob is ok with this, I would suggest to use it instead of V1 patch diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c index dda6092e6d3a..a401ed0463d9 100644 --- a/drivers/of/dynamic.c +++ b/drivers/of/dynamic.c @@ -382,6 +382,

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-25 Thread Bjorn Helgaas
On Thu, Jul 25, 2024 at 11:15:39PM +0530, Amit Machhiwal wrote: > ... > The crash in question is a critical issue that we would want to have > a fix for soon. And while this is still being figured out, is it > okay to go with the fix I proposed in the V1 of this patch? v6.10 has been released alre

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-25 Thread Amit Machhiwal
Hi Lizhi, Rob, Sorry for responding late. I got busy with some other things. On 2024/07/23 02:08 PM, Lizhi Hou wrote: > > On 7/23/24 12:54, Rob Herring wrote: > > On Tue, Jul 23, 2024 at 12:21 PM Lizhi Hou wrote: > > > > > > On 7/23/24 09:21, Rob Herring wrote: > > > > On Mon, Jul 15, 2024 at

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-23 Thread Lizhi Hou
On 7/23/24 12:54, Rob Herring wrote: On Tue, Jul 23, 2024 at 12:21 PM Lizhi Hou wrote: On 7/23/24 09:21, Rob Herring wrote: On Mon, Jul 15, 2024 at 01:52:30PM -0700, Lizhi Hou wrote: On 7/15/24 11:55, Rob Herring wrote: On Mon, Jul 15, 2024 at 2:08 AM Amit Machhiwal wrote: With CONFIG_P

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-23 Thread Rob Herring
On Tue, Jul 23, 2024 at 12:21 PM Lizhi Hou wrote: > > > On 7/23/24 09:21, Rob Herring wrote: > > On Mon, Jul 15, 2024 at 01:52:30PM -0700, Lizhi Hou wrote: > >> On 7/15/24 11:55, Rob Herring wrote: > >>> On Mon, Jul 15, 2024 at 2:08 AM Amit Machhiwal > >>> wrote: > With CONFIG_PCI_DYNAMIC_O

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-23 Thread Lizhi Hou
On 7/23/24 09:21, Rob Herring wrote: On Mon, Jul 15, 2024 at 01:52:30PM -0700, Lizhi Hou wrote: On 7/15/24 11:55, Rob Herring wrote: On Mon, Jul 15, 2024 at 2:08 AM Amit Machhiwal wrote: With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence of a PCI device attached to a P

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-23 Thread Rob Herring
On Mon, Jul 15, 2024 at 01:52:30PM -0700, Lizhi Hou wrote: > > On 7/15/24 11:55, Rob Herring wrote: > > On Mon, Jul 15, 2024 at 2:08 AM Amit Machhiwal > > wrote: > > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > > > of a PCI device attached to a PCI-bridge causes f

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-15 Thread Lizhi Hou
On 7/15/24 11:55, Rob Herring wrote: On Mon, Jul 15, 2024 at 2:08 AM Amit Machhiwal wrote: With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence of a PCI device attached to a PCI-bridge causes following kernel Oops on a pseries KVM guest: RTAS: event: 2, Type: Hotplug Ev

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-15 Thread Lizhi Hou
On 7/15/24 10:23, Bjorn Helgaas wrote: On Mon, Jul 15, 2024 at 09:20:01AM -0700, Lizhi Hou wrote: On 7/15/24 01:07, Amit Machhiwal wrote: With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence of a PCI device attached to a PCI-bridge causes following kernel Oops on a pseries

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-15 Thread Rob Herring
On Mon, Jul 15, 2024 at 2:08 AM Amit Machhiwal wrote: > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > of a PCI device attached to a PCI-bridge causes following kernel Oops on > a pseries KVM guest: > > RTAS: event: 2, Type: Hotplug Event (229), Severity: 1 > Kernel

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-15 Thread Bjorn Helgaas
On Mon, Jul 15, 2024 at 09:20:01AM -0700, Lizhi Hou wrote: > On 7/15/24 01:07, Amit Machhiwal wrote: > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > > of a PCI device attached to a PCI-bridge causes following kernel Oops on > > a pseries KVM guest: > > > > RTAS: ev

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-15 Thread Lizhi Hou
On 7/15/24 01:07, Amit Machhiwal wrote: With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence of a PCI device attached to a PCI-bridge causes following kernel Oops on a pseries KVM guest: RTAS: event: 2, Type: Hotplug Event (229), Severity: 1 Kernel attempted to read use

[PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-15 Thread Amit Machhiwal
With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence of a PCI device attached to a PCI-bridge causes following kernel Oops on a pseries KVM guest: RTAS: event: 2, Type: Hotplug Event (229), Severity: 1 Kernel attempted to read user page (10ec0048) - exploit attempt? (uid: