Re: [PATCH v2] ASoC: fsl_esai: Add ESAI CPU DAI driver

2014-01-10 Thread Nicolin Chen
On Fri, Jan 10, 2014 at 04:52:29PM +, Mark Brown wrote: > On Fri, Jan 10, 2014 at 11:48:25PM +0800, Nicolin Chen wrote: > > > I think I start to understand the point here: If a user only needs to > > playback > > the default case - 44.1KHz for example, the driver can just configure all > > t

Re: [PATCH v2] ASoC: fsl_esai: Add ESAI CPU DAI driver

2014-01-10 Thread Mark Brown
On Fri, Jan 10, 2014 at 11:48:25PM +0800, Nicolin Chen wrote: > I think I start to understand the point here: If a user only needs to playback > the default case - 44.1KHz for example, the driver can just configure all the > dividers once at the beginning, not every time, so that we can save furth

Re: [PATCH v2] ASoC: fsl_esai: Add ESAI CPU DAI driver

2014-01-10 Thread Nicolin Chen
On Fri, Jan 10, 2014 at 01:26:42PM +, Mark Brown wrote: > On Fri, Jan 10, 2014 at 09:03:39PM +0800, Nicolin Chen wrote: > > On Fri, Jan 10, 2014 at 12:04:39PM +, Mark Brown wrote: > > > > This is about what I'd expect but then surely the next step is for the > > > driver to choose a defual

Re: [PATCH v2] ASoC: fsl_esai: Add ESAI CPU DAI driver

2014-01-10 Thread Mark Brown
On Fri, Jan 10, 2014 at 09:03:39PM +0800, Nicolin Chen wrote: > On Fri, Jan 10, 2014 at 12:04:39PM +, Mark Brown wrote: > > This is about what I'd expect but then surely the next step is for the > > driver to choose a defualt BCLK ratio - that's how most drivers work, > > they try to generate

Re: [PATCH v2] ASoC: fsl_esai: Add ESAI CPU DAI driver

2014-01-10 Thread Nicolin Chen
I just received the 'applied' mail. But still want to confirm this topic to see how to refine the driver in the step ahead. On Fri, Jan 10, 2014 at 12:04:39PM +, Mark Brown wrote: > On Fri, Jan 10, 2014 at 10:35:39AM +0800, Nicolin Chen wrote: > > > Resent this because of losing attached file

Re: [PATCH v2] ASoC: fsl_esai: Add ESAI CPU DAI driver

2014-01-10 Thread Mark Brown
On Fri, Jan 10, 2014 at 10:35:39AM +0800, Nicolin Chen wrote: > Resent this because of losing attached file. I don't think your previous mail got sent at all, or at least it must've been caught by spam filters here... > On Fri, Jan 10, 2014 at 10:32:52AM +0800, Nicolin Chen wrote: > > On Thu, Ja

Re: [PATCH v2] ASoC: fsl_esai: Add ESAI CPU DAI driver

2014-01-09 Thread Mark Brown
On Thu, Jan 09, 2014 at 06:57:58PM +0800, Nicolin Chen wrote: > +/** > + * This function configures the ratio between MCLK (HCK) and BCLK (SCK) > + * (For DAI Master Mode only) > + * > + * Note: Machine driver should calculate the ratio to call this function. > + *Only effective after calling

[PATCH v2] ASoC: fsl_esai: Add ESAI CPU DAI driver

2014-01-09 Thread Nicolin Chen
This patch implements a device-tree-only CPU DAI driver for Freescale ESAI controller that supports: - 12 channels playback and 8 channels record. [ Some of the inner transmitters and receivers are sharing same group of pins. So the maxmium 12 output or 8 input channels are only valid if