Re: [PATCH v15 2/5] crash: add a new kexec flag for hotplug support

2024-02-14 Thread Sourabh Jain
On 13/02/24 08:51, Baoquan He wrote: On 02/12/24 at 07:27pm, Sourabh Jain wrote: Hello Baoquan, On 05/02/24 08:40, Baoquan He wrote: Hi Sourabh, .. diff --git a/include/linux/kexec.h b/include/linux/kexec.h index 802052d9c64b..7880d74dc5c4 100644 --- a/include/linux/kexec.h +++ b/inc

Re: [PATCH v15 2/5] crash: add a new kexec flag for hotplug support

2024-02-12 Thread Baoquan He
On 02/12/24 at 07:27pm, Sourabh Jain wrote: > Hello Baoquan, > > On 05/02/24 08:40, Baoquan He wrote: > > Hi Sourabh, > > .. > > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > > index 802052d9c64b..7880d74dc5c4 100644 > > > --- a/include/linux/kexec.h > > > +++ b/include/lin

Re: [PATCH v15 2/5] crash: add a new kexec flag for hotplug support

2024-02-12 Thread Sourabh Jain
Hello Baoquan, On 05/02/24 08:40, Baoquan He wrote: Hi Sourabh, Thanks for the great work. There are some concerns, please see inline comments. Thank you :) On 01/11/24 at 04:21pm, Sourabh Jain wrote: .. Now, if the kexec tool sends KEXEC_CRASH_HOTPLUG_SUPPORT kexec flag to the kernel

Re: [PATCH v15 2/5] crash: add a new kexec flag for hotplug support

2024-02-04 Thread Baoquan He
Hi Sourabh, Thanks for the great work. There are some concerns, please see inline comments. On 01/11/24 at 04:21pm, Sourabh Jain wrote: .. > Now, if the kexec tool sends KEXEC_CRASH_HOTPLUG_SUPPORT kexec flag to > the kernel, it indicates to the kernel that all the required kexec > segment is

[PATCH v15 2/5] crash: add a new kexec flag for hotplug support

2024-01-11 Thread Sourabh Jain
Commit a72bbec70da2 ("crash: hotplug support for kexec_load()") introduced a new kexec flag, `KEXEC_UPDATE_ELFCOREHDR`. Kexec tool uses this flag to indicate to the kernel that it is safe to modify the elfcorehdr of the kdump image loaded using the kexec_load system call. However, it is possible t