Re: [PATCH v12 00/31] Speculative page faults

2020-12-14 Thread Joel Fernandes
On Mon, Dec 14, 2020 at 10:36:29AM +0100, Laurent Dufour wrote: > Le 14/12/2020 à 03:03, Joel Fernandes a écrit : > > On Tue, Jul 07, 2020 at 01:31:37PM +0800, Chinwen Chang wrote: > > [..] > > > > > Hi Laurent, > > > > > > > > > > We merged SPF v11 and some patches from v12 into our platforms. Af

Re: [PATCH v12 00/31] Speculative page faults

2020-12-14 Thread Laurent Dufour
Le 14/12/2020 à 03:03, Joel Fernandes a écrit : On Tue, Jul 07, 2020 at 01:31:37PM +0800, Chinwen Chang wrote: [..] Hi Laurent, We merged SPF v11 and some patches from v12 into our platforms. After several experiments, we observed SPF has obvious improvements on the launch time of applications,

Re: [PATCH v12 00/31] Speculative page faults

2020-12-13 Thread Joel Fernandes
On Tue, Jul 07, 2020 at 01:31:37PM +0800, Chinwen Chang wrote: [..] > > > Hi Laurent, > > > > > > We merged SPF v11 and some patches from v12 into our platforms. After > > > several experiments, we observed SPF has obvious improvements on the > > > launch time of applications, especially for those

Re: [PATCH v12 00/31] Speculative page faults

2020-07-06 Thread Chinwen Chang
On Mon, 2020-07-06 at 14:27 +0200, Laurent Dufour wrote: > Le 06/07/2020 à 11:25, Chinwen Chang a écrit : > > On Thu, 2019-06-20 at 16:19 +0800, Haiyan Song wrote: > >> Hi Laurent, > >> > >> I downloaded your script and run it on Intel 2s skylake platform with > >> spf-v12 patch > >> serials. > >>

Re: [PATCH v12 00/31] Speculative page faults

2020-07-06 Thread Laurent Dufour
Le 06/07/2020 à 11:25, Chinwen Chang a écrit : On Thu, 2019-06-20 at 16:19 +0800, Haiyan Song wrote: Hi Laurent, I downloaded your script and run it on Intel 2s skylake platform with spf-v12 patch serials. Here attached the output results of this script. The following comparison result is st

Re: [PATCH v12 00/31] Speculative page faults

2020-07-06 Thread Chinwen Chang
On Thu, 2019-06-20 at 16:19 +0800, Haiyan Song wrote: > Hi Laurent, > > I downloaded your script and run it on Intel 2s skylake platform with spf-v12 > patch > serials. > > Here attached the output results of this script. > > The following comparison result is statistics from the script outputs

Re: [PATCH v12 00/31] Speculative page faults

2019-06-20 Thread Haiyan Song
Hi Laurent, I downloaded your script and run it on Intel 2s skylake platform with spf-v12 patch serials. Here attached the output results of this script. The following comparison result is statistics from the script outputs. a). Enable THP SPF_0

Re: [PATCH v12 00/31] Speculative page faults

2019-06-14 Thread Laurent Dufour
Le 14/06/2019 à 10:37, Laurent Dufour a écrit : Please find attached the script I run to get these numbers. This would be nice if you could give it a try on your victim node and share the  result. Sounds that the Intel mail fitering system doesn't like the attached shell script. Please find it

Re: [PATCH v12 00/31] Speculative page faults

2019-06-14 Thread Laurent Dufour
Le 06/06/2019 à 08:51, Haiyan Song a écrit : Hi Laurent, Regression test for v12 patch serials have been run on Intel 2s skylake platform, some regressions were found by LKP-tools (linux kernel performance). Only tested the cases that have been run and found regressions on v11 patch serials.

Re: [PATCH v12 00/31] Speculative page faults

2019-06-05 Thread Haiyan Song
Hi Laurent, Regression test for v12 patch serials have been run on Intel 2s skylake platform, some regressions were found by LKP-tools (linux kernel performance). Only tested the cases that have been run and found regressions on v11 patch serials. Get the patch serials from https://github.com/l

Re: [PATCH v12 00/31] Speculative page faults

2019-04-24 Thread Laurent Dufour
Le 22/04/2019 à 23:29, Michel Lespinasse a écrit : Hi Laurent, Thanks a lot for copying me on this patchset. It took me a few days to go through it - I had not been following the previous iterations of this series so I had to catch up. I will be sending comments for individual commits, but befor

Re: [PATCH v12 00/31] Speculative page faults

2019-04-24 Thread Laurent Dufour
Le 23/04/2019 à 11:38, Peter Zijlstra a écrit : On Mon, Apr 22, 2019 at 02:29:16PM -0700, Michel Lespinasse wrote: The proposed spf mechanism only handles anon vmas. Is there a fundamental reason why it couldn't handle mapped files too ? My understanding is that the mechanism of verifying the vm

Re: [PATCH v12 00/31] Speculative page faults

2019-04-23 Thread Michal Hocko
On Tue 23-04-19 05:41:48, Matthew Wilcox wrote: > On Tue, Apr 23, 2019 at 12:47:07PM +0200, Michal Hocko wrote: > > On Mon 22-04-19 14:29:16, Michel Lespinasse wrote: > > [...] > > > I want to add a note about mmap_sem. In the past there has been > > > discussions about replacing it with an interva

Re: [PATCH v12 00/31] Speculative page faults

2019-04-23 Thread Peter Zijlstra
On Tue, Apr 23, 2019 at 05:41:48AM -0700, Matthew Wilcox wrote: > On Tue, Apr 23, 2019 at 12:47:07PM +0200, Michal Hocko wrote: > > Well, I believe we should _really_ re-evaluate the range locking sooner > > rather than later. Why? Because it looks like the most straightforward > > approach to the

Re: [PATCH v12 00/31] Speculative page faults

2019-04-23 Thread Matthew Wilcox
On Tue, Apr 23, 2019 at 12:47:07PM +0200, Michal Hocko wrote: > On Mon 22-04-19 14:29:16, Michel Lespinasse wrote: > [...] > > I want to add a note about mmap_sem. In the past there has been > > discussions about replacing it with an interval lock, but these never > > went anywhere because, mostly,

Re: [PATCH v12 00/31] Speculative page faults

2019-04-23 Thread Anshuman Khandual
On 04/16/2019 07:14 PM, Laurent Dufour wrote: > In pseudo code, this could be seen as: > speculative_page_fault() > { > vma = find_vma_rcu() > check vma sequence count > check vma's support > disable interrupt > check pgd,p4d,...,pte >

Re: [PATCH v12 00/31] Speculative page faults

2019-04-23 Thread Michal Hocko
On Mon 22-04-19 14:29:16, Michel Lespinasse wrote: [...] > I want to add a note about mmap_sem. In the past there has been > discussions about replacing it with an interval lock, but these never > went anywhere because, mostly, of the fact that such mechanisms were > too expensive to use in the pag

Re: [PATCH v12 00/31] Speculative page faults

2019-04-23 Thread Peter Zijlstra
On Mon, Apr 22, 2019 at 02:29:16PM -0700, Michel Lespinasse wrote: > The proposed spf mechanism only handles anon vmas. Is there a > fundamental reason why it couldn't handle mapped files too ? > My understanding is that the mechanism of verifying the vma after > taking back the ptl at the end of t

Re: [PATCH v12 00/31] Speculative page faults

2019-04-22 Thread Michel Lespinasse
Hi Laurent, Thanks a lot for copying me on this patchset. It took me a few days to go through it - I had not been following the previous iterations of this series so I had to catch up. I will be sending comments for individual commits, but before tat I would like to discuss the series as a whole.

[PATCH v12 00/31] Speculative page faults

2019-04-16 Thread Laurent Dufour
This is a port on kernel 5.1 of the work done by Peter Zijlstra to handle page fault without holding the mm semaphore [1]. The idea is to try to handle user space page faults without holding the mmap_sem. This should allow better concurrency for massively threaded process since the page fault hand