Re: [PATCH v1 1/5] drivers/base/memory: rename MMOP_ONLINE_KEEP to MMOP_ONLINE

2020-03-16 Thread David Hildenbrand
On 16.03.20 16:12, Michal Hocko wrote: > On Wed 11-03-20 13:30:22, David Hildenbrand wrote: >> The name is misleading. Let's just name it like the online_type name we >> expose to user space ("online"). > > I would disagree the name is misleading. It just says that you want to > online and keep th

Re: [PATCH v1 1/5] drivers/base/memory: rename MMOP_ONLINE_KEEP to MMOP_ONLINE

2020-03-16 Thread Michal Hocko
On Wed 11-03-20 13:30:22, David Hildenbrand wrote: > The name is misleading. Let's just name it like the online_type name we > expose to user space ("online"). I would disagree the name is misleading. It just says that you want to online and keep the zone type. Nothing I would insist on though. >

Re: [PATCH v1 1/5] drivers/base/memory: rename MMOP_ONLINE_KEEP to MMOP_ONLINE

2020-03-11 Thread Wei Yang
On Wed, Mar 11, 2020 at 01:30:22PM +0100, David Hildenbrand wrote: >The name is misleading. Let's just name it like the online_type name we >expose to user space ("online"). > >Add some documentation to the types. > >Cc: Greg Kroah-Hartman >Cc: Andrew Morton >Cc: Michal Hocko >Cc: Oscar Salvador

[PATCH v1 1/5] drivers/base/memory: rename MMOP_ONLINE_KEEP to MMOP_ONLINE

2020-03-11 Thread David Hildenbrand
The name is misleading. Let's just name it like the online_type name we expose to user space ("online"). Add some documentation to the types. Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: Michal Hocko Cc: Oscar Salvador Cc: "Rafael J. Wysocki" Cc: Baoquan He Cc: Wei Yang Signed-off-by: Davi