Re: [PATCH v1 1/2] PCI/AER: Use for_each_set_bit()

2019-10-02 Thread David Howells
Andy Shevchenko wrote: > > but I confess to being a little ambivalent. It's > > arguably a little easier to read, > > I have another opinion here. Instead of parsing body of for-loop, the name of > the function tells you exactly what it's done. Besides the fact that reading > and parsing two li

Re: [PATCH v1 1/2] PCI/AER: Use for_each_set_bit()

2019-09-30 Thread Andy Shevchenko
On Fri, Sep 27, 2019 at 07:39:13AM -0500, Bjorn Helgaas wrote: > On Tue, Aug 27, 2019 at 06:18:22PM +0300, Andy Shevchenko wrote: > > This simplifies and standardizes slot manipulation code > > by using for_each_set_bit() library function. > > + unsigned long status = info->status & ~info->mask;

Re: [PATCH v1 1/2] PCI/AER: Use for_each_set_bit()

2019-09-27 Thread Bjorn Helgaas
On Tue, Aug 27, 2019 at 06:18:22PM +0300, Andy Shevchenko wrote: > This simplifies and standardizes slot manipulation code > by using for_each_set_bit() library function. > > Signed-off-by: Andy Shevchenko > --- > drivers/pci/pcie/aer.c | 19 --- > 1 file changed, 8 insertions(+)

Re: [PATCH v1 1/2] PCI/AER: Use for_each_set_bit()

2019-09-27 Thread Bjorn Helgaas
On Tue, Aug 27, 2019 at 06:18:22PM +0300, Andy Shevchenko wrote: > This simplifies and standardizes slot manipulation code > by using for_each_set_bit() library function. > > Signed-off-by: Andy Shevchenko Applied both with Kuppuswamy's reviewed-by to pci/aer for v5.5, thanks! > --- > drivers/

Re: [PATCH v1 1/2] PCI/AER: Use for_each_set_bit()

2019-08-29 Thread Kuppuswamy Sathyanarayanan
On 8/27/19 8:18 AM, Andy Shevchenko wrote: This simplifies and standardizes slot manipulation code by using for_each_set_bit() library function. Signed-off-by: Andy Shevchenko Reviewed-by: Kuppuswamy Sathyanarayanan --- drivers/pci/pcie/aer.c | 19 --- 1 file changed, 8

[PATCH v1 1/2] PCI/AER: Use for_each_set_bit()

2019-08-27 Thread Andy Shevchenko
This simplifies and standardizes slot manipulation code by using for_each_set_bit() library function. Signed-off-by: Andy Shevchenko --- drivers/pci/pcie/aer.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c