Re: [PATCH v1 0/4] Revisit MCE handling for UE Errors

2017-09-12 Thread Balbir Singh
On Tue, Sep 12, 2017 at 3:03 PM, Nicholas Piggin wrote: > Hi Balbir, > > Very cool. How are you testing it? Is it failing memory pages > and poisoning them out properly? > Yep, I tested it and it seems to work correctly so far. I am testing this on a simulator with injected MCE UE errors for both

Re: [PATCH v1 0/4] Revisit MCE handling for UE Errors

2017-09-11 Thread Nicholas Piggin
Hi Balbir, Very cool. How are you testing it? Is it failing memory pages and poisoning them out properly? Looks like you have a printk in the machine_check_early path, which you shouldn't. I guess because we don't mark that context as an NMI. Which we could... but I think you want to put as littl

[PATCH v1 0/4] Revisit MCE handling for UE Errors

2017-09-11 Thread Balbir Singh
This patch series is designed to hook up memory_failure on UE errors, this is specially helpful for user_mode UE errors. The first patch is a cleanup patch, it removes dead code. I could not find any users of get_mce_fault_addr(). The second patch walks kernel/user mode page tables in real mode to