Re: [PATCH printk v4 4/6] printk: remove NMI tracking

2021-07-21 Thread Petr Mladek
On Wed 2021-07-21 14:52:15, John Ogness wrote: > On 2021-07-21, Petr Mladek wrote: > >> --- a/kernel/trace/trace.c > >> +++ b/kernel/trace/trace.c > >> @@ -9647,7 +9647,7 @@ void ftrace_dump(enum ftrace_dump_mode > >> oops_dump_mode) > >>tracing_off(); > >> > >>local_irq_save(flags); >

Re: [PATCH printk v4 4/6] printk: remove NMI tracking

2021-07-21 Thread Petr Mladek
On Thu 2021-07-15 21:39:57, John Ogness wrote: > All NMI contexts are handled the same as the safe context: store the > message and defer printing. There is no need to have special NMI > context tracking for this. Using in_nmi() is enough. > > There are several parts of the kernel that are manuall

Re: [PATCH printk v4 4/6] printk: remove NMI tracking

2021-07-21 Thread John Ogness
On 2021-07-21, Petr Mladek wrote: > On Wed 2021-07-21 14:52:15, John Ogness wrote: >> On 2021-07-21, Petr Mladek wrote: >> >> --- a/kernel/trace/trace.c >> >> +++ b/kernel/trace/trace.c >> >> @@ -9647,7 +9647,7 @@ void ftrace_dump(enum ftrace_dump_mode >> >> oops_dump_mode) >> >> tracing_off()

Re: [PATCH printk v4 4/6] printk: remove NMI tracking

2021-07-21 Thread John Ogness
On 2021-07-21, Petr Mladek wrote: >> --- a/kernel/trace/trace.c >> +++ b/kernel/trace/trace.c >> @@ -9647,7 +9647,7 @@ void ftrace_dump(enum ftrace_dump_mode oops_dump_mode) >> tracing_off(); >> >> local_irq_save(flags); >> -printk_nmi_direct_enter(); >> +printk_deferred_enter(

[PATCH printk v4 4/6] printk: remove NMI tracking

2021-07-15 Thread John Ogness
All NMI contexts are handled the same as the safe context: store the message and defer printing. There is no need to have special NMI context tracking for this. Using in_nmi() is enough. There are several parts of the kernel that are manually calling into the printk NMI context tracking in order t