Re: [PATCH net v2] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread Mingming Cao
On Aug 25, 2020, at 10:08 AM, David Miller wrote:From: Dany Madden Date: Tue, 25 Aug 2020 12:56:06 -0400@@ -2011,7 +2017,10 @@ static int do_reset(struct ibmvnic_adapter *adapter,    adapter->req_rx_add_entries_per_subcrq !=    old_num_rx_slots ||    adapter->req_tx_entries_per_subcrq !=-

Re: [PATCH net v2] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread David Miller
From: Dany Madden Date: Tue, 25 Aug 2020 12:56:06 -0400 > @@ -2011,7 +2017,10 @@ static int do_reset(struct ibmvnic_adapter *adapter, > adapter->req_rx_add_entries_per_subcrq != > old_num_rx_slots || > adapter->req_tx_entries_per_subcrq != > -

[PATCH net v2] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread Dany Madden
From: Mingming Cao At the time of do_rest, ibmvnic tries to re-initalize the tx_pools and rx_pools to avoid re-allocating the long term buffer. However there is a window inside do_reset that the tx_pools and rx_pools were freed before re-initialized making it possible to deference null pointers.