Re: [PATCH net-next v5 05/14] net: fman: Map the base address once

2022-10-17 Thread Geert Uytterhoeven
Hi Sean, On Mon, Oct 17, 2022 at 5:34 PM Sean Anderson wrote: > On 10/17/22 11:15 AM, Geert Uytterhoeven wrote: > > On Sat, Sep 3, 2022 at 12:00 AM Sean Anderson > > wrote: > >> We don't need to remap the base address from the resource twice (once in > >> mac_probe() and again in set_fman_mac_p

Re: [PATCH net-next v5 05/14] net: fman: Map the base address once

2022-10-17 Thread Sean Anderson
On 10/17/22 11:15 AM, Geert Uytterhoeven wrote: > Hi Sean, > > On Sat, Sep 3, 2022 at 12:00 AM Sean Anderson wrote: >> We don't need to remap the base address from the resource twice (once in >> mac_probe() and again in set_fman_mac_params()). We still need the >> resource to get the end addre

Re: [PATCH net-next v5 05/14] net: fman: Map the base address once

2022-10-17 Thread Geert Uytterhoeven
Hi Sean, On Sat, Sep 3, 2022 at 12:00 AM Sean Anderson wrote: > We don't need to remap the base address from the resource twice (once in > mac_probe() and again in set_fman_mac_params()). We still need the > resource to get the end address, but we can use a single function call > to get both at o

[PATCH net-next v5 05/14] net: fman: Map the base address once

2022-09-02 Thread Sean Anderson
We don't need to remap the base address from the resource twice (once in mac_probe() and again in set_fman_mac_params()). We still need the resource to get the end address, but we can use a single function call to get both at once. While we're at it, use platform_get_mem_or_io and devm_request_res