Re: [PATCH net-next v2 7/7] net: ethernet: fs_enet: phylink conversion

2024-09-04 Thread Maxime Chevallier
Hi Jakub, On Mon, 2 Sep 2024 18:55:43 -0700 Jakub Kicinski wrote: > On Thu, 29 Aug 2024 18:15:30 +0200 Maxime Chevallier wrote: > > @@ -582,15 +591,12 @@ static void fs_timeout_work(struct work_struct *work) > > > > dev->stats.tx_errors++; > > > > - spin_lock_irqsave(&fep->lock, flags)

Re: [PATCH net-next v2 7/7] net: ethernet: fs_enet: phylink conversion

2024-09-02 Thread Jakub Kicinski
On Thu, 29 Aug 2024 18:15:30 +0200 Maxime Chevallier wrote: > @@ -582,15 +591,12 @@ static void fs_timeout_work(struct work_struct *work) > > dev->stats.tx_errors++; > > - spin_lock_irqsave(&fep->lock, flags); > - > - if (dev->flags & IFF_UP) { > - phy_stop(dev->phydev

[PATCH net-next v2 7/7] net: ethernet: fs_enet: phylink conversion

2024-08-29 Thread Maxime Chevallier
fs_enet is a quite old but still used Ethernet driver found on some NXP devices. It has support for 10/100 Mbps ethernet, with half and full duplex. Some variants of it can use RMII, while other integrations are MII-only. Add phylink support, thus removing custom fixed-link hanldling. This also a