Re: [PATCH net-next 6/6] net: ethernet: fs_enet: phylink conversion

2024-08-29 Thread Maxime Chevallier
Hello Simon, On Wed, 28 Aug 2024 17:32:24 +0100 Simon Horman wrote: > On Wed, Aug 28, 2024 at 11:51:02AM +0200, Maxime Chevallier wrote: > > fs_enet is a quite old but still used Ethernet driver found on some NXP > > devices. It has support for 10/100 Mbps ethernet, with half and full > > duplex

Re: [PATCH net-next 6/6] net: ethernet: fs_enet: phylink conversion

2024-08-28 Thread Simon Horman
On Wed, Aug 28, 2024 at 11:51:02AM +0200, Maxime Chevallier wrote: > fs_enet is a quite old but still used Ethernet driver found on some NXP > devices. It has support for 10/100 Mbps ethernet, with half and full > duplex. Some variants of it can use RMII, while other integrations are > MII-only. >

Re: [PATCH net-next 6/6] net: ethernet: fs_enet: phylink conversion

2024-08-28 Thread Maxime Chevallier
Hello Russell, On Wed, 28 Aug 2024 14:54:57 +0100 "Russell King (Oracle)" wrote: > On Wed, Aug 28, 2024 at 01:44:13PM +0200, Maxime Chevallier wrote: > > Hi Russell, > > > > On Wed, 28 Aug 2024 11:38:31 +0100 > > "Russell King (Oracle)" wrote: > > > > > On Wed, Aug 28, 2024 at 11:51:02AM +0

Re: [PATCH net-next 6/6] net: ethernet: fs_enet: phylink conversion

2024-08-28 Thread Russell King (Oracle)
On Wed, Aug 28, 2024 at 01:44:13PM +0200, Maxime Chevallier wrote: > Hi Russell, > > On Wed, 28 Aug 2024 11:38:31 +0100 > "Russell King (Oracle)" wrote: > > > On Wed, Aug 28, 2024 at 11:51:02AM +0200, Maxime Chevallier wrote: > > > +static int fs_eth_ioctl(struct net_device *dev, struct ifreq *i

Re: [PATCH net-next 6/6] net: ethernet: fs_enet: phylink conversion

2024-08-28 Thread Russell King (Oracle)
On Wed, Aug 28, 2024 at 11:51:02AM +0200, Maxime Chevallier wrote: > +static int fs_eth_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) > +{ > + struct fs_enet_private *fep = netdev_priv(dev); > + > + if (!netif_running(dev)) > + return -EINVAL; Why do you need this c

Re: [PATCH net-next 6/6] net: ethernet: fs_enet: phylink conversion

2024-08-28 Thread Maxime Chevallier
Hi Russell, On Wed, 28 Aug 2024 11:38:31 +0100 "Russell King (Oracle)" wrote: > On Wed, Aug 28, 2024 at 11:51:02AM +0200, Maxime Chevallier wrote: > > +static int fs_eth_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) > > +{ > > + struct fs_enet_private *fep = netdev_priv(dev); > > +

[PATCH net-next 6/6] net: ethernet: fs_enet: phylink conversion

2024-08-28 Thread Maxime Chevallier
fs_enet is a quite old but still used Ethernet driver found on some NXP devices. It has support for 10/100 Mbps ethernet, with half and full duplex. Some variants of it can use RMII, while other integrations are MII-only. Add phylink support, thus removing custom fixed-link hanldling. This also a