Re: [PATCH net-next 4/7] net: freescale: ucc_geth: Fix WOL configuration

2024-11-07 Thread Maxime Chevallier
Hello Andrew, On Thu, 7 Nov 2024 18:49:00 +0100 Andrew Lunn wrote: > > + if (phydev) > > + phy_ethtool_get_wol(phydev, wol); > > + > > if (qe_alive_during_sleep()) > > wol->supported |= WAKE_MAGIC; > > So get WoL will return whatever methods the PHY supports, plus

Re: [PATCH net-next 4/7] net: freescale: ucc_geth: Fix WOL configuration

2024-11-07 Thread Andrew Lunn
On Thu, Nov 07, 2024 at 06:02:51PM +0100, Maxime Chevallier wrote: > The get/set_wol ethtool ops rely on querying the PHY for its WoL > capabilities, checking for the presence of a PHY and a PHY interrupts > isn't enough. Address that by cleaning up the WoL configuration > sequence. > > Signed-off

[PATCH net-next 4/7] net: freescale: ucc_geth: Fix WOL configuration

2024-11-07 Thread Maxime Chevallier
The get/set_wol ethtool ops rely on querying the PHY for its WoL capabilities, checking for the presence of a PHY and a PHY interrupts isn't enough. Address that by cleaning up the WoL configuration sequence. Signed-off-by: Maxime Chevallier --- .../net/ethernet/freescale/ucc_geth_ethtool.c | 19