Re: [ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-19 Thread Pavel Roskin
On Fri, 19 Oct 2012 09:04:14 +0200 Eric Dumazet wrote: > Yes they are some names discrepancies, thats a big deal. > > And we have alloc_skb() / kfree_skb() / skb_clone() > > Why not skb_alloc() / skb_free() / skb_clone() ? > > Some people actually know current code by name of functions, they

Re: [PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-19 Thread Eric Dumazet
On Thu, 2012-10-18 at 20:55 -0700, Joe Perches wrote: > ethernet, ipv4, and ipv6 address testing uses 3 different api naming styles. > > ethernet uses:is__ether_addr > ipv4 uses:ipv4_is_ > ipv6 uses:ipv6_addr_ > > Standardize on the ipv6 style of _addr_ to reduce > the number of s

[PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-18 Thread Joe Perches
ethernet, ipv4, and ipv6 address testing uses 3 different api naming styles. ethernet uses: is__ether_addr ipv4 uses: ipv4_is_ ipv6 uses: ipv6_addr_ Standardize on the ipv6 style of _addr_ to reduce the number of styles to remember. The new consistent styles are: eth_addr_(const u8 *