Re: [PATCH net-next] freescale: ucc_geth: Remove set but unused variables

2025-01-10 Thread Simon Horman
On Fri, Jan 10, 2025 at 12:07:25PM +0100, Christophe Leroy wrote: > > > Le 10/01/2025 à 11:18, Simon Horman a écrit : > > Remove set but unused variables. These seem to provide no value. > > So in the spirit of less being more, remove them. > > Would be good to identify when those variables beca

Re: [PATCH net-next] freescale: ucc_geth: Remove set but unused variables

2025-01-10 Thread Christophe Leroy
Le 10/01/2025 à 11:18, Simon Horman a écrit : Remove set but unused variables. These seem to provide no value. So in the spirit of less being more, remove them. Would be good to identify when those variables became unused. There is for instance commit 64a99fe596f9 ("ethernet: ucc_geth: remo

[PATCH net-next] freescale: ucc_geth: Remove set but unused variables

2025-01-10 Thread Simon Horman
Remove set but unused variables. These seem to provide no value. So in the spirit of less being more, remove them. Flagged by gcc-14 as: .../ucc_geth.c: In function 'ucc_geth_free_rx': .../ucc_geth.c:1708:31: warning: variable 'uf_info' set but not used [-Wunused-but-set-variable] 1708 |