Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-13 Thread Kalesh Singh
On Fri, Dec 13, 2024 at 11:45 AM 'Liam R. Howlett' via kernel-team wrote: > > * Lorenzo Stoakes [241213 10:16]: > > On Fri, Dec 13, 2024 at 10:06:55AM -0500, Kalesh Singh wrote: > > > On Fri, Dec 13, 2024 at 4:00 AM Lorenzo Stoakes > > > wrote: > > ... > > > > > > > On the technical side, Liam i

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-13 Thread Liam R. Howlett
* Lorenzo Stoakes [241213 10:16]: > On Fri, Dec 13, 2024 at 10:06:55AM -0500, Kalesh Singh wrote: > > On Fri, Dec 13, 2024 at 4:00 AM Lorenzo Stoakes > > wrote: ... > > > > On the technical side, Liam is right that the copy-pasted arch code > > has inconsistencies (missing checks, order of chec

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-13 Thread Lorenzo Stoakes
On Fri, Dec 13, 2024 at 10:06:55AM -0500, Kalesh Singh wrote: > On Fri, Dec 13, 2024 at 4:00 AM Lorenzo Stoakes > wrote: > > > > On Thu, Dec 12, 2024 at 05:36:09PM -0800, Andrew Morton wrote: > > > On Thu, 12 Dec 2024 22:51:34 + Lorenzo Stoakes > > > wrote: > > > > > > > You've fundamentally

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-13 Thread Kalesh Singh
On Fri, Dec 13, 2024 at 4:00 AM Lorenzo Stoakes wrote: > > On Thu, Dec 12, 2024 at 05:36:09PM -0800, Andrew Morton wrote: > > On Thu, 12 Dec 2024 22:51:34 + Lorenzo Stoakes > > wrote: > > > > > You've fundamentally violated kernel process and etiquette. I'd be more > > > forgiving, but this

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-13 Thread Lorenzo Stoakes
On Thu, Dec 12, 2024 at 05:36:09PM -0800, Andrew Morton wrote: > On Thu, 12 Dec 2024 22:51:34 + Lorenzo Stoakes > wrote: > > > You've fundamentally violated kernel process and etiquette. I'd be more > > forgiving, but this is at v2 and you've not cc'd KEY people. Twice. This is > > totally un

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-12 Thread Andrew Morton
On Thu, 12 Dec 2024 22:51:34 + Lorenzo Stoakes wrote: > You've fundamentally violated kernel process and etiquette. I'd be more > forgiving, but this is at v2 and you've not cc'd KEY people. Twice. This is > totally unacceptable. See [0] if you are unsure of how to do so. This feels excessi

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-12 Thread Lorenzo Stoakes
NACK. Resend this _as an RFC_, _with the correct maintainers and reviewers cc'd_. You've fundamentally violated kernel process and etiquette. I'd be more forgiving, but this is at v2 and you've not cc'd KEY people. Twice. This is totally unacceptable. See [0] if you are unsure of how to do so. Y

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-12 Thread Matthew Wilcox
On Wed, Dec 11, 2024 at 03:27:38PM -0800, Kalesh Singh wrote: > Hi all, > > This is v2 othe the arch_mmap_hint() series. > > Changes in v2: > - MAP_FIXED case is also handled in arch_mmap_hint() since this is just a > special case of the hint addr being "enforced", per Yang Shi. > - Conso

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-12 Thread Liam R. Howlett
+ Lorenzo Can you please Cc the people listed in the maintainers on the files you are submitting against? You seemed to Cc everyone but the mmap.c file maintainers? * Kalesh Singh [241211 18:28]: > Hi all, > > This is v2 othe the arch_mmap_hint() series. > > Changes in v2: > - MAP_FIXED

[PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-11 Thread Kalesh Singh
Hi all, This is v2 othe the arch_mmap_hint() series. Changes in v2: - MAP_FIXED case is also handled in arch_mmap_hint() since this is just a special case of the hint addr being "enforced", per Yang Shi. - Consolidate most of the error handling in arch_mmap_hint(). - Patch 16 ("mm: Fall