Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-12 Thread Jeff Garzik
Anton Vorontsov wrote: > Otherwise oops will happen if ethernet device has not been opened: > > Unable to handle kernel paging request for data at address 0x014c > Faulting instruction address: 0xc016f7f0 > Oops: Kernel access of bad area, sig: 11 [#1] > MPC85xx > NIP: c016f7f0 LR: c01722a0 CT

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-11 Thread Sergej Stepanov
Am Donnerstag, den 10.01.2008, 19:41 +0100 schrieb Heiko Schocher: > Hello Scott, > > Scott Wood wrote: > > Heiko Schocher wrote: > >> diff --git a/drivers/net/fs_enet/fs_enet-main.c > >> b/drivers/net/fs_enet/fs_enet-main.c > >> index f2a4d39..f432a18 100644 > >> --- a/drivers/net/fs_enet/fs_ene

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-10 Thread Heiko Schocher
Hello Scott, Scott Wood wrote: > Heiko Schocher wrote: >> diff --git a/drivers/net/fs_enet/fs_enet-main.c >> b/drivers/net/fs_enet/fs_enet-main.c >> index f2a4d39..f432a18 100644 >> --- a/drivers/net/fs_enet/fs_enet-main.c >> +++ b/drivers/net/fs_enet/fs_enet-main.c >> @@ -810,6 +810,10 @@ static

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-10 Thread Scott Wood
Heiko Schocher wrote: > diff --git a/drivers/net/fs_enet/fs_enet-main.c > b/drivers/net/fs_enet/fs_enet-main.c > index f2a4d39..f432a18 100644 > --- a/drivers/net/fs_enet/fs_enet-main.c > +++ b/drivers/net/fs_enet/fs_enet-main.c > @@ -810,6 +810,10 @@ static int fs_enet_open(struct net_device *dev

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-10 Thread Heiko Schocher
Hello Scott, Heiko Schocher wrote: > Hello Scott, [...] > Will resend this fixed patch. Here it is: [POWERPC] Fix Ethernet over SCC on a CPM2, also Fix crash in fs_enet_rx_napi() Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> diff --git a/drivers/net/fs_enet/fs_enet-main.c b/driv

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-10 Thread Heiko Schocher
Hello Scott, Scott Wood wrote: > On Wed, Jan 09, 2008 at 01:58:49PM +0100, Heiko Schocher wrote: >> @@ -1312,6 +1312,9 @@ static int __devinit fs_enet_probe(struct of_device >> *ofdev, >> ndev->dev_addr[0], ndev->dev_addr[1], ndev->dev_addr[2], >> ndev->dev_addr[3], ndev->

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-09 Thread Scott Wood
On Wed, Jan 09, 2008 at 01:58:49PM +0100, Heiko Schocher wrote: > @@ -1312,6 +1312,9 @@ static int __devinit fs_enet_probe(struct of_device > *ofdev, > ndev->dev_addr[0], ndev->dev_addr[1], ndev->dev_addr[2], > ndev->dev_addr[3], ndev->dev_addr[4], ndev->dev_addr[5]); >

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-09 Thread Heiko Schocher
Hello Sergej, Wed Jan 9 21:46:06 EST 2008 Sergej Stepanov [EMAIL PROTECTED] wrote: > I got also oops problem with the driver. > What could be false? > After the following patch it functions. > Thanks for any advance. > > diff --git a/drivers/net/fs_enet/fs_enet-main.c > b/drivers/net/fs_enet/fs_en

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-09 Thread Sergej Stepanov
Am Dienstag, den 08.01.2008, 22:05 +0300 schrieb Anton Vorontsov: > Otherwise oops will happen if ethernet device has not been opened: > > Unable to handle kernel paging request for data at address 0x014c > Faulting instruction address: 0xc016f7f0 > Oops: Kernel access of bad area, sig: 11 [#

[PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-08 Thread Anton Vorontsov
Otherwise oops will happen if ethernet device has not been opened: Unable to handle kernel paging request for data at address 0x014c Faulting instruction address: 0xc016f7f0 Oops: Kernel access of bad area, sig: 11 [#1] MPC85xx NIP: c016f7f0 LR: c01722a0 CTR: REGS: c79ddc70 TRAP: 0300