Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-11 Thread Vineet Gupta
On 11/7/19 8:27 PM, Anshuman Khandual wrote: > > On 11/08/2019 12:35 AM, Vineet Gupta wrote: >> On 11/6/19 8:44 PM, Anshuman Khandual wrote: > */ > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE > #include > #endif This in wrong.  C

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-07 Thread Anshuman Khandual
On 11/08/2019 12:35 AM, Vineet Gupta wrote: > On 11/6/19 8:44 PM, Anshuman Khandual wrote: >> >>> */ -#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE #include #endif >>> This in wrong.  CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE is a just

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-07 Thread Vineet Gupta
On 11/6/19 8:44 PM, Anshuman Khandual wrote: > >> >>> */ >>> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE >>> +#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE >>> #include >>> #endif >> This in wrong.  CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE is a just a glue >> toggle, >> used only in Kconfig files (and no

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-07 Thread Anshuman Khandual
On 11/07/2019 06:24 PM, Michael Ellerman wrote: > Anshuman Khandual writes: >> On 11/06/2019 12:11 PM, Christophe Leroy wrote: >>> Le 06/11/2019 à 04:22, Anshuman Khandual a écrit : On 10/28/2019 10:59 AM, Anshuman Khandual wrote: > +    --- > +    | arc

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-07 Thread Michael Ellerman
Anshuman Khandual writes: > On 11/06/2019 12:11 PM, Christophe Leroy wrote: >> Le 06/11/2019 à 04:22, Anshuman Khandual a écrit : >>> On 10/28/2019 10:59 AM, Anshuman Khandual wrote: +    --- +    | arch |status| +    --- +    |  

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-07 Thread Anshuman Khandual
On 11/06/2019 11:37 PM, Vineet Gupta wrote: > On 11/5/19 7:03 PM, Anshuman Khandual wrote: >> But should not pfn_pmd() be encapsulated inside >> HAVE_ARCH_TRANSPARENT_HUGEPAGE >> at the minimum (but I would say it should be available always, nonetheless) >> when >> the platform subscribes to T

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-06 Thread Vineet Gupta
On 11/5/19 7:03 PM, Anshuman Khandual wrote: > But should not pfn_pmd() be encapsulated inside HAVE_ARCH_TRANSPARENT_HUGEPAGE > at the minimum (but I would say it should be available always, nonetheless) > when > the platform subscribes to THP irrespective of whether THP is enabled or not. For AR

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-05 Thread Anshuman Khandual
On 11/06/2019 12:11 PM, Christophe Leroy wrote: > > > Le 06/11/2019 à 04:22, Anshuman Khandual a écrit : >> >> >> On 10/28/2019 10:59 AM, Anshuman Khandual wrote: >>> +    --- >>> +    | arch |status| >>> +    --- >>> +    |   alpha: | TODO |

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-05 Thread Christophe Leroy
Le 06/11/2019 à 04:22, Anshuman Khandual a écrit : On 10/28/2019 10:59 AM, Anshuman Khandual wrote: +--- +| arch |status| +--- +| alpha: | TODO | +| arc: | TODO | +| arm: | TODO | +| arm6

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-05 Thread Anshuman Khandual
On 10/28/2019 10:59 AM, Anshuman Khandual wrote: > +--- > +| arch |status| > +--- > +| alpha: | TODO | > +| arc: | TODO | > +| arm: | TODO | > +| arm64: | ok | > +| c6x: | TODO |

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-05 Thread Anshuman Khandual
On 11/06/2019 01:06 AM, Gerald Schaefer wrote: > On Mon, 28 Oct 2019 10:59:22 +0530 > Anshuman Khandual wrote: > >> This adds tests which will validate architecture page table helpers and >> other accessors in their compliance with expected generic MM semantics. >> This will help various archi

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-05 Thread Anshuman Khandual
On 11/06/2019 04:00 AM, Vineet Gupta wrote: > Hi Anshuman, Hello Vineet, > > On 11/4/19 4:00 PM, Anshuman Khandual wrote: >> On 10/28/2019 10:59 AM, Anshuman Khandual wrote: >>> This adds tests which will validate architecture page table helpers and >>> other accessors in their compliance wit

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-05 Thread Vineet Gupta
Hi Anshuman, On 11/4/19 4:00 PM, Anshuman Khandual wrote: > On 10/28/2019 10:59 AM, Anshuman Khandual wrote: >> This adds tests which will validate architecture page table helpers and >> other accessors in their compliance with expected generic MM semantics. >> This will help various architectures

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-05 Thread Anshuman Khandual
On 10/28/2019 10:59 AM, Anshuman Khandual wrote: > This adds tests which will validate architecture page table helpers and > other accessors in their compliance with expected generic MM semantics. > This will help various architectures in validating changes to existing > page table helpers or ad

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-05 Thread Anshuman Khandual
On 10/28/2019 10:59 AM, Anshuman Khandual wrote: > This adds tests which will validate architecture page table helpers and > other accessors in their compliance with expected generic MM semantics. > This will help various architectures in validating changes to existing > page table helpers or addit

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-05 Thread Gerald Schaefer
On Mon, 28 Oct 2019 10:59:22 +0530 Anshuman Khandual wrote: > This adds tests which will validate architecture page table helpers and > other accessors in their compliance with expected generic MM semantics. > This will help various architectures in validating changes to existing > page table hel

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-03 Thread Anshuman Khandual
On 10/29/2019 04:01 PM, Qian Cai wrote: > > >> On Oct 28, 2019, at 1:29 AM, Anshuman Khandual >> wrote: >> >> This adds tests which will validate architecture page table helpers and >> other accessors in their compliance with expected generic MM semantics. >> This will help various architect

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-10-29 Thread Qian Cai
> On Oct 28, 2019, at 1:29 AM, Anshuman Khandual > wrote: > > This adds tests which will validate architecture page table helpers and > other accessors in their compliance with expected generic MM semantics. > This will help various architectures in validating changes to existing > page table

[PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-10-27 Thread Anshuman Khandual
This adds tests which will validate architecture page table helpers and other accessors in their compliance with expected generic MM semantics. This will help various architectures in validating changes to existing page table helpers or addition of new ones. This test covers basic page table entry