Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-15 Thread Tabi Timur-B04825
On Aug 14, 2012, at 10:56 PM, "Jia Hongtao-B38951" wrote: >> >>> >>> +EXPORT_SYMBOL_GPL(mpc85xx_pci_err_probe); >> >> Make this EXPORT_SYMBOL. >> > > Hi Timur and Kumar: > > I'm a little confused. > Should we remove _GPL for upstream version too? Yes. > > -Hongtao. ___

RE: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-14 Thread Jia Hongtao-B38951
> -Original Message- > From: Tabi Timur-B04825 > Sent: Saturday, August 11, 2012 9:11 PM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Wood Scott- > B07421 > Subject: Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie

Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-11 Thread Tabi Timur-B04825
On Fri, Aug 10, 2012 at 3:19 AM, Jia Hongtao wrote: > > +EXPORT_SYMBOL_GPL(mpc85xx_pci_err_probe); Make this EXPORT_SYMBOL. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozl

Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Kumar Gala
On Aug 10, 2012, at 3:19 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Kumar Gala
On Aug 10, 2012, at 3:19 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

[PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a